258410 - fix dynamic matrix transforms

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Alex Fritze]

Dynamic updates of transforms in code like the following are currently not
working. Upcoming patch fixes that.

<svg>
  <circle transform="matrix(1 0 0 1 0 0)"/>
</svg>

circle_element.transform.baseVal.getItem(0).matrix.a = 10;

Expected Result: new transform matrix [10 0 0 1 0 0] should be applied to circle.
Actual Result: matrix gets the new value, but circle is not redrawn with new
transform.

Comment 1

[Alex Fritze]

Attachment: fix

Comment 2

[Jonathan Watt [:jwatt]]

r=+ from me. Not sure how to add that to the patch without removing the request
for review from tor.

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 158181 [details] [diff] [review]
fix

r=[e-mail]
As discussed with tor

Comment 4

[Jonathan Watt [:jwatt]]

Alex, can you check in your patch so we can close this bug please?

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: fix updated to tip

Updated Alex's patch to tip. Alex, do you mind if I check this in for you?

Comment 6

[Martijn Wargers (dead)]

Uhm, was the patch checked in? What's the status of this bug?

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 187549 [details] [diff] [review]
fix updated to tip

Requesting approval for branch. Alex says he doesn't mind if one of us checks
this in for him. This is SVG only and low risk IMO. It fixes a conformance
issue, so I think it's important we include this for Firefox 1.5.

Comment 8

[Jonathan Watt [:jwatt]]

checked in on trunk and branch