Closed
Bug 258503
Opened 21 years ago
Closed 21 years ago
Comment in nsIURIContentListener.idl is incorrect
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhpedemonte, Assigned: jhpedemonte)
Details
(Keywords: fixed-aviary1.0, fixed1.7.5)
Attachments
(1 file)
1.27 KB,
patch
|
Biesinger
:
review+
bzbarsky
:
superreview+
mkaply
:
approval-aviary+
mkaply
:
approval1.7.5+
|
Details | Diff | Splinter Review |
The comment for the function OnStartURIOpen has the following description for
the return values:
62 * @return <code>true</code> if the load can continue;
63 * <code>false</code> if the open should be aborted.
However, every consumer of this function actually uses 'false' to denote that
the load should continue.
Assignee | ||
Comment 1•21 years ago
|
||
Comment 2•21 years ago
|
||
Comment on attachment 158235 [details] [diff] [review]
patch
oh great, wrong comments in frozen interfaces... lovely...
Attachment #158235 -
Flags: superreview?(bzbarsky)
Attachment #158235 -
Flags: review+
Updated•21 years ago
|
Assignee: general → jhpedemonte
Component: Browser-General → File Handling
![]() |
||
Comment 3•21 years ago
|
||
Comment on attachment 158235 [details] [diff] [review]
patch
sr=bzbarsky. I think we want this on the branches.
Attachment #158235 -
Flags: superreview?(bzbarsky)
Attachment #158235 -
Flags: superreview+
Attachment #158235 -
Flags: approval1.7.x?
Attachment #158235 -
Flags: approval-aviary?
Comment 4•21 years ago
|
||
Comment on attachment 158235 [details] [diff] [review]
patch
agreed
a=mkaply for comment only change
Attachment #158235 -
Flags: approval1.7.x?
Attachment #158235 -
Flags: approval1.7.x+
Attachment #158235 -
Flags: approval-aviary?
Attachment #158235 -
Flags: approval-aviary+
Assignee | ||
Comment 5•21 years ago
|
||
Checked in everywhere.
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0,
fixed1.7.x
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•