258524 - No password manager in sunbird

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

sunbird doesn't show the remember checkbox in password dialogs.

The is because toolkit/components/build isn't build. But build can't be added to
DIRS, because build includes stuff from satchel, and it won't compile.
A solution would be to not special case sunbird in
toolkit/components/Makefile.in, and let it have the same components as firefox.
Except that it includes download, which conflicts with
xpfe/components/download-manager. the Makefile.in for xpfe contains special
stuff for firefox, but no good stuff for sunbird.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

cc-ing darin and bsmedberg, because this is really a xpfe-vs-toolkit makefile
problem.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

I forget to mention: i found this bug while trying to make a static build. Using
a normal build it will likely compile, not sure if it will really work.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Errors while building:

../../../dist/lib/components/libtoolkitcomps.a(nsModule.o)(.text+0x0): In
function `nsDownloadProxy::AddRef()':
/home/michiel/mozhack/tree5/mozilla/toolkit/components/downloads/src/nsDownloadProxy.h:226:
multiple definition of `nsDownloadProxy::AddRef()'
../../../dist/lib/components/libappcomps.a(nsModule.o)(.text+0x0):/home/michiel/mozhack/tree5/mozilla/xpfe/components/download-manager/src/nsDownloadProxy.h:237:
first defined here
../../../dist/lib/components/libtoolkitcomps.a(nsModule.o)(.text+0xa8): In
function `nsDownloadProxy::Release()':
/home/michiel/mozhack/tree5/mozilla/toolkit/components/downloads/src/nsDownloadProxy.h:226:
multiple definition of `nsDownloadProxy::Release()'
../../../dist/lib/components/libappcomps.a(nsModule.o)(.text+0xa8):/home/michiel/mozhack/tree5/mozilla/xpfe/components/download-manager/src/nsDownloadProxy.h:237:
first defined here
../../../dist/lib/components/libtoolkitcomps.a(nsModule.o)(.text+0x18c): In
function `nsDownloadProxy::QueryInterface(nsID const&, void**)':
/home/michiel/mozhack/tree5/mozilla/toolkit/components/downloads/src/nsDownloadProxy.h:226:
multiple definition of `nsDownloadProxy::QueryInterface(nsID const&, void**)'
../../../dist/lib/components/libappcomps.a(nsModule.o)(.text+0x18c):/home/michiel/mozhack/tree5/mozilla/xpfe/components/download-manager/src/nsDownloadProxy.h:237:
first defined here
collect2: ld returned 1 exit status
gmake[3]: *** [sunbird-bin] Error 1
gmake[3]: Leaving directory
`/home/michiel/mozhack/tree5/obj-static/calendar/sunbird/app'

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

*** Bug 257249 has been marked as a duplicate of this bug. ***

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: whack some makefiles

This patch whack some makefiles.
It assumes that sunbird want to use all components from toolkit. It doesn't
need them all, but i don't want to ifdef it more. There will be one true
toolkit one day, that should take care of it all.
It does minimize the number of xpfe components. Luckily, the one included don't
need to build the build dir.

Comment 6

[Benjamin Smedberg]

Comment on attachment 166171 [details] [diff] [review]
whack some makefiles

>Index: xpfe/Makefile.in

> ifneq (,$(MOZ_PHOENIX)$(MOZ_XULRUNNER))
> DIRS += \
>         browser/public \
>         browser/src \
>         $(NULL)
> else
>+ifdef MOZ_SUNBIRD
>+else
> DIRS += browser components/shistory communicator global
> endif
>+endif

Maybe ifndef MOZ_SUNBIRD would be easier to read? ;)

r=me from the mozilla side, I don't know whether you need another calendar
reviewer. (Is there a doc on what the calendar review process is?)

Comment 7

[Mostafa Hosseini]

Comment on attachment 166171 [details] [diff] [review]
whack some makefiles

r=me. For the calendar side of things, this change can be checked in.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 166171 [details] [diff] [review]
whack some makefiles

>Index: xpfe/components/Makefile.in
>+#sunbird
>+DIRS    = \
>+                console \
>+                intl \
>+                shistory \
I think intl isn't stricly needed.
I do need to add filepicker though, for gtk1 builds, and maybe other platforms
shistory will be build from other places, so i can remove that.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 10

[Kenneth Herron]

The change to toolkit/components/build/Makefile.in contained a typo which caused
the ifneq test to always succeed, where it should fail for thunderbird. The
thunderbird tinderbox has been broken for hours. A fix has been checked in:

Checking in Makefile.in;
/cvsroot/mozilla/toolkit/components/build/Makefile.in,v  <--  Makefile.in
new revision: 1.15; previous revision: 1.14
done

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in to sunbird 0.2 branch too

Comment 12

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!