258592 - popup blocked notification reappears after switching tabs

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Michael Lefevre]

Using: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040907
Firefox/1.0 PR (NOT FINAL)

Possibly related to bug 255837 (i.e. the fix didn't complete fix that)

Steps
1. Go to site with popup (e.g. http://www.popuptest.com/popuptest12.html ),
notification appears
2. Navigate to another site (I clicked a bookmark to mozillazine), notification
disappears
3. Switch to another tab
4. Switch back to first tab

Actual result:
Blocked popup notification for original site reappears

Expected:
Notification should stay dead because it's not for the right site

Comment 1

[teleGUISE]

Using: Mozilla/5.0 (Windows; U; Win98; rv:1.7.3) Gecko/20040913 Firefox/0.10

In addition:
To step #2 above this also includes navigating to a home page set 
as 'about:blank' and then continuing with step 3,4

Navigating 2 or more sites away like above does NOT exhibit this behavior, even 
if navigating back to the site immediately after the one being popup blocked
but will repeat itself if you do navigate back to a site popup blocked
and then only navigate one site away.

If applicable even if doing a Reload with(override cache) on the site first
navigated to that exhibits the behavior originally makes no difference.

Comment 2

[chris hofmann]

dan can you have a look at this one?

Comment 3

[Marcia Knous [:marcia]]

I tested this using today's branch build (Mozilla/5.0 (Macintosh; U; PPC Mac OS
X Mach-O; en-US; rv:1.7.3) Gecko/20041004 Firefox/0.10) and was able to
reproduce this using the site that Michael references.  However, I did not get
the same behavior when I visited www.orbitz.com (has a popup), navigated to
www.yahoo.com, switched tabs, and then returned to www.yahoo - in this instance
there was no popup notification lingering. Just thought I would add this for
info purposes.

Comment 4

[chris hofmann]

dan, any thoughts on this one?

Comment 5

[Michael Lefevre]

Just to echo Marcia's comments, I discovered the same thing myself after filing
this (and after nominating as a 1.0 blocker) but before Marcia commented. I
haven't been able to reproduce this on any page other than the pop-up tester
page mentioned, which launches a bunch of varied pop-up types at once.  If it's
just that pop-up tester page that causes it, then I'm not sure this needs to be
a 1.0 blocker.

Comment 6

[Bill Gianopoulos [:WG9s]]

My guess is that this has to do with the pop-up that the tester attempts to open
when you leave the page.

Comment 7

[Dan M]

The undead "popup blocked" notification is indeed caused by the unload popup. In
my (slightly modified but I think it shouldn't matter) current trunk build it's
much simpler to see this than this bug report implies. With one tab:

1) Load popuptest12.html
2) Load www.mozilla.org

Note the "popup blocked" notification for www.mozilla.org.

The notification is cleared when the tabbrowser gets an unload event. When I see
this problem happen, tabbrrowser receives the unload event (and resets its popup
state) before it receives the DOMPopupBlocked event from the last page's unload
handler. Therefore the blocked popup notification lives on and is attributed to
the next window. There's no guarantee which of the tabbrowser or the content
window receives the unload event first, is there? So isn't this scheme
guaranteed to have flaky results?

Comment 8

[Dan M]

Attachment: clear unlikely popup notifications in the load handler

Doublecheck all popup notifications accumulated between the unload and load
events, and remove those that don't seem to belong to the current window. Fixes
the bug for me.

Comment 9

[Dan M]

Comment on attachment 162031 [details] [diff] [review]
clear unlikely popup notifications in  the load handler

(Note attachFormFill() will now be called more often, but that method does
nothing if called more than once.)

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 162031 [details] [diff] [review]
clear unlikely popup notifications in  the load handler

r+a=[e-mail]

Comment 11

[Dan M]

Fixed on the Aviary branch. Bug 250716 must land on the trunk before this one can.

Comment 12

[Fareed Rizkalla]

I think you should set a variable. Variable Popup UI closed notification
"popUIclosed is 0". or maybe use some exciting UI variable. make the existing
variable use a 2 cell configuration.
If closed is to 1.

if (!popUIclosed)
 showPopup();

Comment 13

[Dan M]

OK. Not sure why that would help. But the Aviary branch landing has fixed this
on the trunk now, too. Closing.

Comment 14

[mmortal03]

Wow.  I'm seeing this again:  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060730 BonEcho/2.0b1