Closed
Bug 258642
Opened 20 years ago
Closed 20 years ago
Unused functions [PRUni]charPtrArrayTo[C]StringArray & [C]StringArrayTo[PRUni]charPtrArray
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikael, Assigned: mikael)
References
()
Details
Attachments
(1 file, 1 obsolete file)
21.06 KB,
patch
|
neil
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
These functions are not used and could be removed (or #if 0:ed) http://lxr.mozilla.org/seamonkey/ident?i=PRUnicharPtrArrayToStringArray http://lxr.mozilla.org/seamonkey/ident?i=StringArrayToPRUnicharPtrArray
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #162737 -
Flags: superreview?(bienvenu)
Attachment #162737 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 2•20 years ago
|
||
I looked at the callers of the methods. The first two methods are both used by nsAbDirectoryQueryArguments because it decided to use an nsCStringArray internally. The first method is also used by a bunch of callers to nsAbDirectoryQueryArguments because they couldn't work out how to pass an array of one string. You could easily end up removing the entire file ;-)
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 162737 [details] [diff] [review] patch to #if 0 them Neil, I'll look into this and attach a new fix.
Attachment #162737 -
Attachment is obsolete: true
Attachment #162737 -
Flags: superreview?(bienvenu)
Attachment #162737 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Updated•20 years ago
|
Summary: Unused function PRUnicharPtrArrayToStringArray & StringArrayToPRUnicharPtrArray → Unused functions [PRUni]charPtrArrayTo[C]StringArray & [C]StringArrayTo[PRUni]charPtrArray
Assignee | ||
Comment 4•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #163239 -
Attachment description: patch, removesnsAbUtils.cpp (but not .h) → patch, removes nsAbUtils.cpp (but not .h)
Attachment #163239 -
Flags: superreview?(bienvenu)
Attachment #163239 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 5•20 years ago
|
||
Comment on attachment 163239 [details] [diff] [review] patch, removes nsAbUtils.cpp (but not .h) >mReturnProperties.AppendCString(nsDependentCString(returnPropertiesArray[i])); It's always nice when people fix bugs instead of blindly moving/copying code :-) >+ const char *arr = "card:nsIAbCard"; >+ rv = arguments->SetReturnProperties (1, &arr); I'm just wondering whether something along these lines will be more readable - by the compiler as well as the programmer ;-) static const char *arr[] = { "card: nsIAbCard" }; rv = arguments->SetReturnProperties (NS_ARRAY_LENGTH(arr), arr);
Attachment #163239 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Updated•20 years ago
|
Attachment #163239 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 6•20 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•