Closed
Bug 258708
Opened 21 years ago
Closed 21 years ago
use sheet URI instead of base URI where appropriate
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha4
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
This is a followup to bug 255538. At some points in that patch, I used base URI
for backwards compatibility where I should really be using sheet URI.
Essentially, base URI should be used only for resolving relative URLs and sheet
URI should be used for everything else -- but I was a little too conservative
when doing bug 255538. This bug covers fixing that.
|
Assignee | |
Comment 1•21 years ago
|
||
I already fixed half of this in my bustage fix last night:
http://tinderbox.mozilla.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/content/html/style/src&command=DIFF_FRAMESET&file=nsCSSParser.cpp&rev1=3.276&rev2=3.277&root=/cvsroot
|
|
Assignee | |
Comment 2•21 years ago
|
||
|
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 158453 [details] [diff] [review]
patch
Could you review this one-liner along with the bustage fix in comment 1?
Attachment #158453 -
Flags: superreview?(bzbarsky)
Attachment #158453 -
Flags: review?(bzbarsky)
|
||
Comment 4•21 years ago
|
||
Comment on attachment 158453 [details] [diff] [review]
patch
r+sr=bzbarsky
Attachment #158453 -
Flags: superreview?(bzbarsky)
Attachment #158453 -
Flags: superreview+
Attachment #158453 -
Flags: review?(bzbarsky)
Attachment #158453 -
Flags: review+
|
|
Assignee | |
Comment 5•21 years ago
|
||
Fix checked in to trunk, 2004-09-10 12:01 -0700.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha4
You need to log in
before you can comment on or make changes to this bug.
Description
•