Closed
Bug 258793
Opened 20 years ago
Closed 20 years ago
background-attachment checks should check that there's an image
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha4
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: perf, Whiteboard: [patch])
Attachments
(1 file)
|
5.60 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
When we check background-attachment in ways that could hurt performance, we should also check that there's really a background image. There isn't always one -- authors might use CSS rules that cascade in interesting ways, e.g., bug 255812.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha4
|
|
Assignee | |
Updated•20 years ago
|
Attachment #158482 -
Flags: superreview?(roc)
Attachment #158482 -
Flags: review?(roc)
Attachment #158482 -
Flags: superreview?(roc)
Attachment #158482 -
Flags: superreview+
Attachment #158482 -
Flags: review?(roc)
Attachment #158482 -
Flags: review+
|
|
Assignee | |
Comment 2•20 years ago
|
||
Fix checked in to trunk, 2004-09-12 22:39 -0700.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Comment 3•20 years ago
|
||
This broke VC7.1 builds, for which the forward-declaration of imgIRequest in nsStyleStruct.h does apparently not suffice. it is probably best to un-inline this function.
|
|
||
Comment 4•20 years ago
|
||
that vc7 bustage is bug 259151
|
||
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•