Closed
Bug 258819
Opened 21 years ago
Closed 21 years ago
[FIX]Setting window.status should not flush
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha4
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: perf)
Attachments
(1 file)
1.45 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Given the patch to bug 129844, there is absolutely no reason to flush on setting
window.status (since the paint will be async anyway). So the patch to bug 97227
should simply be backed out, in my opinion.
Failing that, we can add a new constant to nsIWebBrowserChrome's SetStatus()
constants to trigger sync updates and flush only if it's set...
Thoughts, jst?
![]() |
Assignee | |
Updated•21 years ago
|
Target Milestone: --- → mozilla1.8alpha4
![]() |
Assignee | |
Comment 1•21 years ago
|
||
![]() |
Assignee | |
Updated•21 years ago
|
Priority: -- → P1
Summary: Setting window.status should not flush → [FIX]Setting window.status should not flush
![]() |
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 158517 [details] [diff] [review]
Like so
See comment 0 for the other option that I think may be OK.
Attachment #158517 -
Flags: superreview?(jst)
Attachment #158517 -
Flags: review?(jst)
Comment 3•21 years ago
|
||
Comment on attachment 158517 [details] [diff] [review]
Like so
r+sr=jst
Attachment #158517 -
Flags: superreview?(jst)
Attachment #158517 -
Flags: superreview+
Attachment #158517 -
Flags: review?(jst)
Attachment #158517 -
Flags: review+
![]() |
Assignee | |
Comment 4•21 years ago
|
||
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•