258864 - View > 'Full Screen' menu entry does not become ticked / checked when in full screen mode

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Oomingmak]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

The 'Full Screen' menu item is not tickable / checkable, and so it does not have
the capacity to reflect the current state of the browser window or allow
intuitive de-selection of full screen mode. 

Admittedly, this is only a problem when the menu can be seen.

Reproducible: Always
Steps to Reproduce:
1. Install AutoHide extension http://www.krickelkrackel.de/autohide/autohide.htm
(or use any alternative means of permitting menu display while in full screen mode)

2. Configure Autohide to show menus when in full screen mode 

3. Switch to full screen mode (Menu: View > Full Screen)

4. Hover mouse at the top edge of screen to make the menu appear

5. Go to Menu: View > Full Screen

Actual Results:  
The Full Screen menu item is not ticked / checked to match the current full
screen window status. This makes it look as if there is no menu option to 'exit'
from full screen mode. You therefore have to 'enable' full screen mode again in
order to exit.

Expected Results:  
The Full Screen menu item should have had a tick / check mark in front if it, to
indicate that this particular menu option is currently activated. This makes it
 clearer that you should use the same menu option again (untick / uncheck the
option) in order to exit from full screen mode.

This issue is specifically about the incorrect menu status of the Full Screen
menu item. The menu item is "toggle-able", but yet it has no visual feedback to
indicate this mode of operation (so it appears just like any other single
function menu item). 

The fact that an extension (or other method) is currently required to show the
menu is not relevant (as this was just the means of displaying the problem). 

IE implements this better. If you go into full screen mode in IE and then right
click on the toolbar to show menus, you will see that when you are in Full
screen mode, the 'Full Screen' menu item is ticked. Unticking this menu item
will cause an exit from full screen mode returning the browser window to normal.
IE's 'Full Screen' menu item always correctly reflects the current status of the
browser window.

Comment 1

[Ryan Polk (Quark)]

*** Bug 258865 has been marked as a duplicate of this bug. ***

Comment 2

[Mike Connor [:mconnor]]

you can access it via Alt-V without extensions.

Its trivial though, and definitely not on radar.

Comment 3

[Chris Messina]

This is also a problem on Firefox/Mac.

Comment 4

[David Tenser [:djst]]

Attachment: Fix: adds an id and checkbox toggle

My very first Firefox patch. History is written in bug 258864! :)

Comment 5

[Itay Perl]

Patch working :)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050428
Firefox/1.0+

Comment 6

[Asaf Romano (gone)]

Was it checked in?

Comment 7

[Asaf Romano (gone)]

Answer: no.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Trunk:

browser/base/content/browser-menubar.inc:
new revision: 1.58; previous revision: 1.57

browser/base/content/browser.js:
new revision: 1.485; previous revision: 1.484

Comment 9

[:Gavin Sharp [email: [e-mail]]]

1.8 Branch:
mozilla/browser/base/content/browser-menubar.inc; new revision: 1.57.2.1;
mozilla/browser/base/content/browser.js; new revision: 1.479.2.9;