258892 - When changing themes, Firefox reverts to uninstalled theme if you fail to select a new theme

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Marcia Knous [:marcia]]

Seen while testing Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3)
Gecko/20040911 Firefox/0.10.

I also checked and this behavior was also present in 0.9. Also able to reproduce
on Windows XP.

STR:

1.  Install a few themes to FF.
2.  Use one of the themes.
3.  Uninstall that theme, but "forget" to select a new theme. Restart FF.
4.  Observe that FF starts with the theme that you just installed.

I guess I would expect that if you fail to choose a theme that FF would just
revert to the default theme.

Comment 1

[Pierre Chanial]

Attachment: on linux

The same steps on linux make the browser unusable and there's no easy way to
put it back in shape.
This screenshot shows a horked today build (with the tool menu open) compared
to a normal build.

Comment 2

[Benjamin Smedberg]

Do you have chrome JS errors logged, and does anything show up in the JS console?

Comment 3

[Steffen Wilberg]

I get the same result as in the screenshot, when I leave dynamic skin switching
disabled, select a non-current theme, click Use, then click Uninstall, then
restart Firefox.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

revert to default theme if uninstalling the currently selected theme

Comment 5

[Benjamin Smedberg]

By the way, backend chrome-registry changes to make theme fallbacks more correct
occurred in the mostly-duplicate bug 259203

Comment 6

[Marcia Knous [:marcia]]

Verifying on all three platforms, with 20041007 Firefox/0.10.1