Closed Bug 258901 Opened 20 years ago Closed 19 years ago

View Image should be disabled / not show on context menu when only image is being viewed

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: richard.corbin, Assigned: romain)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

patch
1.71 KB, patch
mconnor
: review+
asa
: approval-aviary1.1a2+
Details | Diff | Splinter Review
patch-2
907 bytes, patch
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review
Using: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040910 Firefox/0.10 When looking at just an image (i.e. location bar reads 'www.site.com/image.gif'), it is possible to right-click the image and select 'View Image', which basically just reloads the page. If the user believes the image has changed and wants to reload it they should use f5 / refresh (instead of 'right-click > View Image'). The 'View Image' option should be removed from context menu (prefered) or be made disabled. Appreciate this is trivial. I think this is a simple fix, and would be a nice to have.
Attached patch patch — — Splinter Review
Attachment #186101 - Flags: review?(firefox)
Assignee: firefox → r.bezut
Severity: trivial → minor
OS: Windows XP → All
QA Contact: bugzilla → menus
Hardware: PC → All
Version: unspecified → Trunk
Comment on attachment 186101 [details] [diff] [review] patch Transferring review request to mconnor, Blake hasn't been reviewing lately.
Attachment #186101 - Flags: review?(firefox) → review?(mconnor)
Attachment #186101 - Flags: review?(mconnor) → review+
Attachment #186101 - Flags: approval-aviary1.1a2?
Attachment #186101 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Whiteboard: [checkin needed]
fix checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Attached patch patch (obsolete) — — Splinter Review
When the stand alone image is in a frame, "View Image" is still useful.
Attachment #209229 - Flags: review?
Attachment #209229 - Flags: review? → review?(mconnor)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 209229 [details] [diff] [review] patch trivial fix, incredibly low risk
Attachment #209229 - Flags: review?(mconnor)
Attachment #209229 - Flags: review+
Attachment #209229 - Flags: approval1.8.1+
Whiteboard: [checkin needed]
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
I backed this out of the 1.8 branch because of tinderbox orange. Not that I understand why this would cause orange.
Attached patch patch-2 — — Splinter Review
There was a non-printable character in my previous patch between "||" and "this". I am sorry about that...
Attachment #209229 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
checked back with the newer patch
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Attachment #227381 - Flags: approval1.8.1? → approval1.8.1+
Is the followup patch checked in to the trunk? Please make sure it's checked in to both the trunk and the MOZILLA_1_8_BRANCH; when it's checked in to the latter, please mark fixed1.8.1.
Whiteboard: [checkin needed (1.8 branch)]
mozilla/browser/base/content/browser.js 1.479.2.164
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: