259076 - proxy mode setting in gnome-network-preferences is not treated well by Mozilla

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Ganesh]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040831 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040831 Firefox/0.9.1+

When we change the proxy mode setting like direct connection,proxy or auto-proxy
in gnome-network-preferences, it doesn't gets changed in the the Firefox
preference setting. Whereas other setting like proxy etc works fine. This is in
continuation to bug #202388.

Reproducible: Always
Steps to Reproduce:
1.Open gnome-network-preferences and set  the proxy mode to direct connection
2.Open Mozilla proxy setting to look for change
3.

Actual Results:  
Mozilla proxy setting doen't change when the gnome-network-preferences proxy
setting is changed

Expected Results:  
Mozilla preferences should also reflect the setting as gnome-network-preferences.

Comment 1

[Ganesh]

I tried adding "network.proxy.mode", "/system/proxy/mode" to gconf_pref_list.inc
file and changed the nsSystemPref.cpp by adding network.proxy.mode to
sSysPrefList  array. It did not work.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

You have set config.use_system_prefs to true, right?

Comment 3

[Ganesh]

Yep I did

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch to extend gconf proxy settings

(this is a patch against aviary)

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 160322 [details] [diff] [review]
patch to extend gconf proxy settings

Benjamin, could you please have a look at it?

Comment 6

[Benjamin Smedberg]

Comment on attachment 160322 [details] [diff] [review]
patch to extend gconf proxy settings

Bumping this to somebody who might actually review it.

Comment 7

[Darin Fisher]

Comment on attachment 160322 [details] [diff] [review]
patch to extend gconf proxy settings

sure, this seems reasonable to me.

r=darin

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in