259126 - sites/exceptions list allows invalid hostnames

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Richard Keppler]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

In the cookie exceptions dialog, if you enter nothing in to the site you want to
allow or block cookies from, you can allow the blank item

Reproducible: Always
Steps to Reproduce:
1. Cookies -> exceptions - press spacebar to enable block/allow buttons.
2. Press Allow. Now an empty line (one space character) is allowed.
3. Remove the allowed item (select it/ press remove)


Actual Results:  
Text box is now null - no characters in it - but block/allow buttons are active.

Expected Results:  
Block/allow buttons should be inactive (unable to use them) unless characters
are present in text box.

Comment 1

[Mike Connor [:mconnor]]

-> me

steal my own code from Seamonkey to disable the buttons until there's not a
blank space.

Comment 2

[Steffen Wilberg]

I guess e.g. "a" shouldn't be allowed either.

Comment 3

[Mike Connor [:mconnor]]

"a" is legitimate, but there's no domains that end in "a"

"uk" would block all UK domains, for example.

Comment 4

[Richard Keppler]

I wouldn't necessarily try to check for that much validity. Don't discount 
internal corporate use where domains can have any name.

Comment 5

[Mike Connor [:mconnor]]

Attachment: beef up the validity checking for hostnames

Comment 6

[Mike Connor [:mconnor]]

I actually made it a tad more robust, short of getting into some serious regexp
hackery this should be pretty good.

Comment 7

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change