The default bug view has changed. See this FAQ.

Status

()

Core
Plug-ins
VERIFIED FIXED
13 years ago
11 years ago

People

(Reporter: mkaply, Assigned: Peter Weilbacher)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
x86
OS/2
fixed1.8.0.5, fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
Windows default plugin has changed so we need OS/2 changes.
(Reporter)

Comment 1

13 years ago
Created attachment 158768 [details] [diff] [review]
First pass

This gets things working again.

Comment 2

12 years ago
Was this ever checked in?  On Seamonkey 1.0a, it appears to me that the stream
isn't being killed for the plugin data: 
  NPN_DestroyStream(pInstance, stream, NPRES_DONE);

Can't we point these to http://plugindoc.mozdev.org/OS2.html instead?
#define DEFAULT_PLUGINFINDER_URL "http://plugins.netscape.com/plug-in_finder.adp"
#define JVM_SMARTUPDATE_URL "http://plugins.netscape.com/plug-in_finder.adp"
(Reporter)

Comment 3

12 years ago
Nope, I never checked this in because I thought they were going to port the new
plugin code to SeaMonkey so this wouldn't be relevant. I'll take a look at the
code again.
(Assignee)

Comment 4

11 years ago
Created attachment 207847 [details] [diff] [review]
sync anew

Update of Mike's patch, also fixes some warnings and has two whitespace cleanups. It also changes the two URLs to point to Steve's mozdev page. Compiles on trunk.
Assignee: mozilla → mozilla
Attachment #158768 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #207847 - Flags: superreview?(mozilla)
Attachment #207847 - Flags: review?(mozilla)
(Assignee)

Comment 5

11 years ago
Hmm, it just doesn't work. If I go to

http://www.dtmb.de/Rundgang/Neubau/body_schifffahrt_Aufbau01.html

and double click the jigsaw piece I am asked by the dialog to download the QT plugin from http://www.apple.com/quicktime/download/ and when I click on "Get the Plug-in" it goes to that website. With the new version the same dialog appears but it does not go to that page any more. Hmm, it seems I have to do some debugging (tomorrow or when I get the time).
(Assignee)

Comment 6

11 years ago
OK, that's because "application.use_ns_plugin_finder" is false by default, so the patch is OK.
(Reporter)

Comment 7

11 years ago
Comment on attachment 207847 [details] [diff] [review]
sync anew

r=mkaply
Attachment #207847 - Flags: superreview?(mozilla)
Attachment #207847 - Flags: superreview+
Attachment #207847 - Flags: review?(mozilla)
Attachment #207847 - Flags: review+
(Reporter)

Comment 8

11 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 9

11 years ago
Checked in on just the trunk, or branches too?
(Reporter)

Comment 10

11 years ago
trunk

should I put it on the branches?

Comment 11

11 years ago
Yes, please.  :)
(Assignee)

Comment 12

11 years ago
In principle I agree that this should go into the branches, but I think we should test the trunk version first.
(Assignee)

Comment 13

11 years ago
Steve, does the new version (from trunk or in my newest unofficial releases) work the way you expect it to?

Comment 14

11 years ago
(In reply to comment #13)
> Steve, does the new version (from trunk or in my newest unofficial releases)
> work the way you expect it to?

Yes, the streams do stop, thanks!
Status: RESOLVED → VERIFIED
(Assignee)

Comment 15

11 years ago
Comment on attachment 207847 [details] [diff] [review]
sync anew

OK, so we should get this on the branche(s). This is OS/2 only and was shown on the trunk to work.
Attachment #207847 - Flags: approval1.8.0.5?
Attachment #207847 - Flags: approval-branch-1.8.1?(mozilla)
Comment on attachment 207847 [details] [diff] [review]
sync anew

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #207847 - Flags: approval1.8.0.5?
Attachment #207847 - Flags: approval1.8.0.5+
Attachment #207847 - Flags: approval-branch-1.8.1?(mozilla)
Attachment #207847 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 17

11 years ago
OK, checked into both branches.
Keywords: fixed1.8.0.5, fixed1.8.1
You need to log in before you can comment on or make changes to this bug.