259140 - Update default plugin

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Kaply [:mkaply]]

Windows default plugin has changed so we need OS/2 changes.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: First pass

This gets things working again.

Comment 2

[Steve Wendt]

Was this ever checked in?  On Seamonkey 1.0a, it appears to me that the stream
isn't being killed for the plugin data: 
  NPN_DestroyStream(pInstance, stream, NPRES_DONE);

Can't we point these to http://plugindoc.mozdev.org/OS2.html instead?
#define DEFAULT_PLUGINFINDER_URL "http://plugins.netscape.com/plug-in_finder.adp"
#define JVM_SMARTUPDATE_URL "http://plugins.netscape.com/plug-in_finder.adp"

Comment 3

[Mike Kaply [:mkaply]]

Nope, I never checked this in because I thought they were going to port the new
plugin code to SeaMonkey so this wouldn't be relevant. I'll take a look at the
code again.

Comment 4

[Peter Weilbacher]

Attachment: sync anew

Update of Mike's patch, also fixes some warnings and has two whitespace cleanups. It also changes the two URLs to point to Steve's mozdev page. Compiles on trunk.

Comment 5

[Peter Weilbacher]

Hmm, it just doesn't work. If I go to

http://www.dtmb.de/Rundgang/Neubau/body_schifffahrt_Aufbau01.html

and double click the jigsaw piece I am asked by the dialog to download the QT plugin from http://www.apple.com/quicktime/download/ and when I click on "Get the Plug-in" it goes to that website. With the new version the same dialog appears but it does not go to that page any more. Hmm, it seems I have to do some debugging (tomorrow or when I get the time).

Comment 6

[Peter Weilbacher]

OK, that's because "application.use_ns_plugin_finder" is false by default, so the patch is OK.

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 207847 [details] [diff] [review]
sync anew

r=mkaply

Comment 8

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 9

[Steve Wendt]

Checked in on just the trunk, or branches too?

Comment 10

[Mike Kaply [:mkaply]]

trunk

should I put it on the branches?

Comment 11

[Steve Wendt]

Yes, please.  :)

Comment 12

[Peter Weilbacher]

In principle I agree that this should go into the branches, but I think we should test the trunk version first.

Comment 13

[Peter Weilbacher]

Steve, does the new version (from trunk or in my newest unofficial releases) work the way you expect it to?

Comment 14

[Steve Wendt]

(In reply to comment #13)
> Steve, does the new version (from trunk or in my newest unofficial releases)
> work the way you expect it to?

Yes, the streams do stop, thanks!

Comment 15

[Peter Weilbacher]

Comment on attachment 207847 [details] [diff] [review]
sync anew

OK, so we should get this on the branche(s). This is OS/2 only and was shown on the trunk to work.

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 207847 [details] [diff] [review]
sync anew

approved for 1.8.0 branch, a=dveditz for drivers

Comment 17

[Peter Weilbacher]

OK, checked into both branches.