259224 - Control j shortcut key appears 2 times in Tools menu

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P3)

Description

[Nagappan]

In tools menu both web search and downloads menuitem in Tools menu has the
shortcut key Control+j. I'm using GTK2 based Firefox.

Comment 1

[Aaron Leventhal]

Obviously these needs to be cleaned up if it's still a problem. Any takers for a
trivial fix?

Comment 2

[Pratik]

So Firefox doesn't have the same shortcut anymore. Can we just close this as
invalid?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The fix for this was in bug 250396's attachment 157066 [details] [diff] [review], and was apparently
undone by the aviary branch landing.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch

Remove the shortcut key for downloads, in Linux only.

Comment 5

[Asaf Romano (gone)]

Checking in browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <-- 
browser-menubar.inc
new revision: 1.46; previous revision: 1.45
done

Comment 6

[Steffen Wilberg]

Something is wrong here. In Linux, the download manager opens on pressing
Ctrl+Y, but that shortcut is not shown in the menu.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Gah, what an obvious mistake. The ifdef in this patch gives the same result
regardless of platform.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Er, no, I was wrong. There is no key defined on Linux. There is something wacky
going on though,
http://lxr.mozilla.org/mozilla/source/browser/base/content/browser-sets.inc#218
uses ifdef XP_GNOME.

Comment 9

[Steffen Wilberg]

XP_GNOME is defined in the same file as "XP_UNIX, but not XP_MACOSX".

So we browser-sets.inc defines "key_openDownloads" for Linux except Mac (#ifdef
XP_GNOME) and the same "key_openDownloads" for other platforms (#else). XP_GNOME
seems to work fine because Ctrl+Y opens the download manager on Linux.

Looks like we should use that on all platforms in browser-menubar.inc.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

The Ctrl+Y not showing up in the menu regression was fixed in bug 313572.