259234 - Event start time is greater than end time [if negative default duration]

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Anupama]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0)
Build Identifier: Event start time is greater than end time (negative values are accepted)

menubar->tools->options->general.Negative values are also accepted in the 
default event length.   

Reproducible: Always
Steps to Reproduce:
1.Click on menu tools.
2.Click on submenu option.
3.click on tab general.
4.On default event length,enter -60
5.click on ok.
6.open new event.


Actual Results:  
1.The event start time is greater than end time by "60 Minutes".
    


Expected Results:  
1.The event start time should be less than end time.

Comment 1

[Torsten]

Confirmed with Mozilla Calendar 2004091012-cal 
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko 20040803 
Thunderbird/0.7.3
There is no warning like  while creating a new event. The warning 'Your start
time is after your end time' in the dialogue box is not printed until the start
or end time is manually confirmed with the time picker.

Comment 2

[desmor]

Not only that, but at least in Sunbird, this also accepts non-numeric values. 
For these it outputs 0.

Interestly enough, this also allows for non-decimal inputs also.  ie. 0xF is
considered 15 minutes.  Also this means that 09 is not in oct, and thus
erroneous and zero.

Comment 3

[gekacheka]

Re: comment #0
Clearly there is a workaround for this bug: 
set the default event length to a positive number.

--> minor (was critical)

I don't expect many users to enter negative numbers without the motive of
testing the error checking, so I think this bug is low priority.

Comment 4

[Joey Minta]

Good first bug: We already have a hasPositiveIntegerValue function that could be used here: http://lxr.mozilla.org/mozilla/source/calendar/resources/content/applicationUtil.js#381

Comment 5

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 6

[bugzilla]

Attachment: Patch

I've just used the validateNaturalNums function. This patch also fixes the same problem with the defaultsnoozetime.

Comment 7

[Matthew (lilmatt) Willis]

Comment on attachment 257954 [details] [diff] [review]
Patch 

r=lilmatt for post-0.5

Comment 8

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 9

[Andreas Treumann]

verified in Lightning build 2007070304.

Comment 10

[Damian Szczepanik]

Litmus testcase 4445 created