259363 - Go to line in viewsourced does not scroll anymore. Broken in Firefox 1.0PR

Status: RESOLVED WORKSFORME

(Toolkit :: View Source, defect)

Description

[mgueury]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

The go to line in View source is broken in Firefox 1.0 PR.
(was working in 0.93)


Reproducible: Always
Steps to Reproduce:
1. take a page with the HTML size > size of the screen 
2. For ex: http://www.mozilla.org/
3. Press CTRL+U (view source)
4. Press CTRL+L (go to line) then 100 
   ok

nothing

5. scroll down manually and you will see that the line is selected.
   but the scrolling did not happened.





Expected Results:  
The line should be selected and displayed.

I am trying to add HTML validation to mozilla. And jumping to the line
with errors is needed. 

See: http://users.skynet.be/mgueury/mozilla

Other jump to line are probably broken too.

I debugged the javascript code and it looks right.
But this call seems to call a wrong function.

It looks like 2 functions got the same name. And
that the wrong one is called.

-----------------------------------------------------
  var selCon = getSelectionController();
-----------------------------------------------------

I tested by replacing the string getSelectionController()
everywhere in the file by getSourceSelectionController()
and it works again fine.

Comment 1

[mgueury]

I mean that the change need to be done in ViewSource.js
where the getSelectionController is declared and used.

And or in browser.js where the other conflictiong function is defined.

Comment 2

[sidki]

It's broken for me too in 0917 aviary Sweetlou.
Still works in 0917 trunk Beast.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a4) Gecko/20040917
Firefox/0.9.1+

Comment 3

[sidki]

This bugs breaks the "Jump to line with error" functionality in the JS console
as well.
The viewSource.js - modified according to comment #0 - works fine in 0919 aviary.

Comment 4

[mgueury]

This problem appears only when my extension was present.
I use a browser for help and the viewsource. So, I 
included the .js file of the both part. viewsource.js and browser.js

The 2nd function in browser.js with the same name did not exist in 0.93.

It caused this error only when my extension was present.
I work-around it by rewritting a function and by not including the
browser.js file.

Comment 5

[mgueury]

Did a mistake here. I had to check that the problem was not 
there after removing all extensions installed. Sorry.

Comment 6

[Michael Lefevre]

in that case this bug should not be resolved as "fixed", but "worksforme"

Comment 7

[Michael Lefevre]

resolving WORKSFORME per reporter's comment