259478 - Empty focus box next to checkmarks, looks like ... elispsis (start, due, completed in task dialog)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Anupama]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0)
Build Identifier: sunbird 0.2

Fundamental of Testing (Frontend)


Reproducible: Always
Steps to Reproduce:
1) Click File 
2) Clcik New Task.
3)Enter the all with start ,Due date ,Completed date.
4)Select unchecked or select the ... is displayed. 



Actual Results:  
No Window opens.



Expected Results:  
The meaning  of the ... means from selecting this this will open the another 
windows.

Comment 1

[gekacheka]

I think this refers to the dotted focus box that appears next to a checkbox.  If
a checkbox has a label, this box appears around the checkbox label when it has
focus.  Since there is no label, the box looks a bit like an ellipsis "...".

If you agree, please change the title to "Empty focus box next to checkmarks in
task and event dialogs" and change severity to Trivial (appearance issue, no
functionality disabled).

Comment 2

[gekacheka]

This depends theme: 
  In (Aviary/FF/TB/SB) classic theme, a checkbox shows focus with a dotted box
around the text label, which is to the side of the checkbox.   In the task
dialog, the checkbox labels are empty (the labels are separate boxes so they can
be aligned in a grid).  It looks like the empty label box has some width and no
height, so the dotted border appears as an ellipsis (...). 
  In Seamonkey modern theme, a checkbox shows focus with a border around the
entire box and label, so this problem does not occur.

Comment 3

[Joey Minta]

*** Bug 273379 has been marked as a duplicate of this bug. ***

Comment 4

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 5

[Joey Minta]

Attachment: test patch

This *should* fix it, but I don't have a windows box to test it.  If someone could do that, and report back, I'd appreciate it.

Comment 6

[Matthew (lilmatt) Willis]

(In reply to comment #5)
> Created an attachment (id=231137) [edit]
> test patch
> 
> This *should* fix it, but I don't have a windows box to test it.  If someone
> could do that, and report back, I'd appreciate it.

Tested successfully on WinXP with latest nightly + patch.

Comment 7

[Joey Minta]

Comment on attachment 231137 [details] [diff] [review]
test patch

requesting review now that lilmatt has tested.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 231137 [details] [diff] [review]
test patch

r=dmose

Comment 9

[Thomas Benisch]

(In reply to comment #7)
               <checkbox id="todo-has-duedate" oncommand="updateDueDate();" class="todo-only"/>
-              <datetimepicker id="todo-duedate" onchange="onEndTimeChange();" class="todo-only"/>
+              <datetimepicker id="todo-duedate" onchange="onEndTimeChange();" class="todo-only checkbox-no-label"/>

The ... are still displayed when the due date checkbox gets the focus.
The reason is, that you set the checkbox-no-label class at the datetimepicker
instead of the checkbox with id="todo-has-duedate".

r=tbe with that fixed

Comment 10

[Joey Minta]

patch checked in.

Comment 11

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060802 Calendar/0.3a2+:

Checkbox for Due Date still shows this issue. See also Comment #9.

Comment 12

[Joey Minta]

(In reply to comment #11)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060802
> Calendar/0.3a2+:
> 
> Checkbox for Due Date still shows this issue. See also Comment #9.
> 
Turns out I fixed that review comment in the wrong tree :-(.  A fix has been checked in.