259890 - don't call Remove(PR_TRUE) to delete a file

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/nsExternalHelperAppService.cpp#2226

I'd prefer to pass PR_FALSE here, to be absolutely certain that this will not
blow away an entire directory

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 159127 [details] [diff] [review]
patch

r=bzbarsky

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.269; previous revision: 1.268
done

Comment 4

[Darin Fisher]

Comment on attachment 159127 [details] [diff] [review]
patch

see bug 259708 for an example of where this bites badly.  i think we should get
this patch on the branches as a safety measure at least even though bug 259708
should probably be fixed at a higher level.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 159127 [details] [diff] [review]
patch

a=dveditz for 1.7x

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 159127 [details] [diff] [review]
patch

a=dveditz for aviary as well, I'm not actually endowed but this is a no-brainer
given safety plus blocking bug 259708

Comment 7

[Alex Vincent [:WeirdAl]]

Callek says attachment 159127 [details] [diff] [review] will not apply to Firefox trunk.  It looks like
the contextual code is quite different.

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: Aviary 1.0 port

Comment 9

[Alex Vincent [:WeirdAl]]

attachment 160032 [details] [diff] [review] is identical to attachment 160030 [details] [diff] [review] (which is filed under bug
259708)

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 160032 [details] [diff] [review]
Aviary 1.0 port

r+sr=bzbarsky on this patch, fwiw.

Comment 11

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 160032 [details] [diff] [review]
Aviary 1.0 port

<bz> You can just unset the approval requests; the a=dveditz applies.
<bz> Since biesi's patch is approved for both.

Comment 12

[Alex Vincent [:WeirdAl]]

setting blocking flags to assist in getting checkin of ported patch to aviary
and 1.7.x stable branch.

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

In on aviary and 1.7.x.

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

> Callek says attachment 159127 [details] [diff] [review] will not apply to Firefox trunk.

surely you meant branch here? because this code is not forked by firefox.


adding fixed1.7.x keyword (checkin by vlad, 2004-09-24 21:58). thanks for doing
the checkin for me.

also, I'm not sure that this actually fixes bug 259708. please test.