259903 - save as plain text saves the file with the wrong extention (.html instead of .txt)

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect, P2)

Description

[David Fedoruk]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a4) Gecko/20040915 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a4) Gecko/20040915 Camino/0.8+

When saving a web page as plain text the dialogue box is selected as plain text
but the file name is still file.html and the resulting file is the comlete html
code.

Reproducible: Always
Steps to Reproduce:
1. File --> Save As
2. Select plain text (this is already selected)
3. click Save

Actual Results:  
The selected file is saved as an html document not plain text.

Expected Results:  
The page should have been saved as a plain text documenting with NO html tags.

Comment 1

[Mike Pinkerton (not reading bugmail)]

does this work in 0.8.1? was it a regression on the trunk?

Comment 2

[David Fedoruk]

Attachment: File Save As example

Since there seems to be some puzzlement about what is being saved, this is an
example saved from this buiild 2004091808 (v0.8+) URL:
http://www.saila.com/usage/layouts/

Comment 3

[David Fedoruk]

It seems this is done on purpose
<http://bugzilla.mozilla.org/show_bug.cgi?id=16800>. However a problem still
persists in that Camino AND Mozillz save text documents with the wrong
extension. Camino saves this text document with an html extension where it
should be .txt

Comment 4

[Jasper]

Is it just me, or does the whole save as plain text seem stupid as it will
always be the same as "save as source" as both files will be plain text. Only
difference will be the extension. Perhaps removing "save as plain text"?

Comment 5

[David Fedoruk]

I've now changed the bug to a problem with correct file extension.

Comment 6

[Jasper]

Confriming and handing over to Josh.

Comment 7

[Jasper]

Let's confirm the shall we :)

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this related to bug 181029?

Comment 9

[Samuel Sidler (old account; do not CC)]

(In reply to comment #8)
> Is this related to bug 181029?

Sounds like it is, yeah. It could also be an encoding problem, similar to our
treatment of gzip files on some (improperly configured) servers.

Comment 10

[Nick Kreeger]

Problem occurs in Deer Park Alpha 2, so it is a gecko/necko issue

Comment 11

[Simon Fraser [no longer active]]

Well, we copied some of their downloading code. I think we choose our own file
extension in the download sniffer code.

Comment 12

[Nick Kreeger]

inspecting smfrs comments......

Comment 13

[Nick Kreeger]

Taking. Problem is that we are saving correctly, and the sniffer correctly
assigns the content to plain/text, but the .html extension is not getting
changed to .txt when the "plain text" option is saved.. 

Comment 14

[Nick Kreeger]

OK, Have a working solution, to append .txt to the file name, but a question
about what to do here. 

// Assume the file is called index.html

Should we just rename the file to index.txt OR should we add the extension
index.html.txt???

I vote for option 2 as you can keep track of what plain text you were trying to
save.

Any other ideas, suggestions???

Comment 15

[Samuel Sidler (old account; do not CC)]

I agree with option 2 as it will allow people to know what they were saving.

Comment 16

[Nick Kreeger]

Perhaps changing the extension to index.html.txt in the text field on the save
dialog?

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When we save pages (like Bugzilla bug) as HTML Complete, they get saved as
foo.cgi.html, so foo.cgi.txt seems appropriate here, too.  

That new name is suggested in the Save dialogue for HTML Complete, so Plain Text
should also suggest the name it's going to use.

(Seems like right now the logic for all three "Save as" variations is the same.)

Comment 18

[Nick Kreeger]

Attachment: This patch appends .txt if the save option is plain text

This patch will append .txt to a file name if the option to save is "plain
text". The filename in the save dialog cannont be manually changed since the
dialog is run with one command with a return value. The best way I could find
to fix a simple problem like this is to simply append a .txt to the filename
after the dialog closes and the user selected "plain text".

Comment 19

[Nick Kreeger]

working on actually updating changes with a hack in a NSSavePanel accessory..

Comment 20

[Nick Kreeger]

Comment on attachment 191696 [details] [diff] [review]
This patch appends .txt if the save option is plain text

Reworking patch so removing review, sorry for the spam

Comment 21

[Nick Kreeger]

Attachment: First version of patch, hacks the nssavepanel to add correct extensions

Comment 22

[Nick Kreeger]

Attachment: Update accessoryviews.nib, adds hooks for the FilterViewController in the patch

Comment 23

[Nick Kreeger]

Attachment: Oops ran the wrong option on the diff this is the correct patch, version 1a

Comment 24

[Simon Fraser [no longer active]]

Looks good! Tested and checked in, trunk and branch.