259979 - Changes to keyword.URL require restarting Firefox

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jesse Ruderman]

If you change keyword.URL but don't restart Firefox, keyword searches (triggered
by typing non-URLs into the address bar) still use the old keyword.URL.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/keyword/src/nsKeywordProtocolHandler.cpp#65

Comment 2

[Darin Fisher]

yeah, this should be easy to fix.  

Comment 3

[Jesse Ruderman]

Should this be fixed by getting rid of init() and the member variable, or by
observing changes to preferences and calling init() again?

Comment 4

[Darin Fisher]

since keyword URLs are not loaded that often, it might be better to just check
the pref each time it is needed instead of implementing an observer scheme.

Comment 5

[Son Le]

Attachment: hack v0

Check keyword.URL pref each time it is needed by removing Init() function and
place code inside NewChannel(). 

Also removed redundant mKeywordURL member.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 165753 [details] [diff] [review]
hack v0

r=biesi, although I think it would be better to return NS_ERROR_NOT_AVAILABLE
if the pref isn't available or empty.

please ask [e-mail] for superreview.

Comment 7

[Darin Fisher]

Comment on attachment 165753 [details] [diff] [review]
hack v0

>Index: netwerk/protocol/keyword/src/nsKeywordProtocolHandler.cpp

>+    nsXPIDLCString url;
>+    rv = prefs->GetCharPref("keyword.URL", getter_Copies(url));
>+    // if we can't find a keyword.URL keywords won't work.
>+    if (NS_FAILED(rv) || !url || !*url) return NS_ERROR_FAILURE;

I think there is no reason to make this check so complex.  This is
all you need:

      nsXPIDLCString url;
      prefs->GetCharPref("keyword.URL", getter_Copies(url));
      // if we can't find a keyword.URL keywords won't work.
      if (url.IsEmpty())
	  return NS_ERROR_FAILURE;


sr=darin with that change.

Comment 8

[Son Le]

Attachment: hack v1

change

Comment 9

[Son Le]

Do I need to request r= and sr= again?

Comment 10

[Darin Fisher]

no need to re-request reviews after people gave +

fixed-on-trunk

Comment 11

[benc]

This wasn't firefox specific, was it?