260003 - Firefox 1.0 pre release: pressing RETURN in empty search field should not print "Phrase not found"

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Norbert]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

There is the new search bar in Firefox 1.0. If the edit field is empty and I
press RETURN, "Phrase not found" is printed.

I think in this case nothing should happen.

(Previous versions of Firefox also have done nothing if confirming the empty
search window.)

Reproducible: Always
Steps to Reproduce:

Comment 1

[Norbert]

Should we set Version to "1.0 Branch"? (I don't want to do something wrong here.)

Comment 2

[Norbert]

I set version to 1.0 branch. I hope this is correct.

Comment 3

[Gertjan]

searching for an empty string logically returns phrase not found. because every
piece of the page contains something.. But this is a "beauty error" imo, because
why would you search for an empty string...

(but this could be fixed for the beauty by checking the input string)

Comment 4

[Norbert]

(In reply to comment #3)

> (but this could be fixed for the beauty by checking the input string)

I really think that this should be fixed.

Comment 5

[Michael Clackler]

Attachment: patch to fix

This patch only registers RETURN if the find string is not empty, solving the
problem of an empty find string returning "not found".

Comment 6

[Blake Ross]

Fixed.