260010 - Make Mozilla Calendar project validate

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Anne (:annevk)]

I'm willing to make the Mozilla Calendar project validate. I was wondering,
currently the templates are including another file, 'menucontent'. Shouldn't
that menu be in the general style of mozilla.org, as seen on
<http://www.mozilla.org/about/>?

fantasai, is it possible to turn multiviews on for these page?

Simon, is it ok with you if I just check in the validating page without asking
review for every patch? I won't change content.

Comment 1

[fantasai]

Yes, they should have the same menu style. Talk to dbaron about that: doing it
through the mozilla.org template system is a bit quirky and you will need to be
building the site locally to test those changes.

I would rather not turn on MultiViews unless we're doing a thorough
reorganization of the pages. As part of that I would like to set up a section
for Sunbird in the Products section, but we probably should wait on that until
the calendar team feels ready enough to ask for it.

Comment 2

[Simon Paquet [:sipaq]]

(In reply to comment #0)
> I'm willing to make the Mozilla Calendar project validate. I was wondering,
> currently the templates are including another file, 'menucontent'. Shouldn't
> that menu be in the general style of mozilla.org, as seen on
> <http://www.mozilla.org/about/>?

Yes, it should use the same style and it did during the beta phase.
Unfortunately it didn't work in the final version. If you can correct that, go
ahead.

> Simon, is it ok with you if I just check in the validating page without asking
> review for every patch? I won't change content.

I'm totally fine with you changing the code without touching the content.

Comment 3

[Anne (:annevk)]

All pages validate as HTML 4.01 Strict and are updated to match the style/markup
guide a bit better. (I must admit most of the pages have (had) a good author
compared to the other pages on mozilla.org.)

fantasai, what do you mean with reorganization of the pages? I assume other
pages are made for the product page? Things like a roadmap should probably stay
on the project page.

dbaron, could you take a look at the menu? (See also comment 0 and comment 1.)

Comment 4

[fantasai]

Mainly, moving things that would belong on a /products page out of /projects. We
can set up MultiViews at that point, since things will be moving around anyway.

Comment 5

[Anne (:annevk)]

Shall I open a separate bug for the menu? Or should that happen when this is
moved to /products ?

Comment 6

[Daniel Wang]

> Shall I open a separate bug for the menu? Or should that happen when this is
> moved to /products ?

What does the page owner say about the menu?

Comment 7

[Anne (:annevk)]

(In reply to comment #6)
> What does the page owner say about the menu?

Please read comment 2.

Comment 8

[Anne (:annevk)]

How about just changing the included file:
<http://www.mozilla.org/projects/calendar/menucontent>. If that file uses the
same structure has the navigation is using on other places at mozilla.org it
shouldn't be a problem. As in using |<ul id="nav">| et cetera.

Example:
 <http://www.mozilla.org/projects/help-viewer/>

Included file:
 <http://www.mozilla.org/projects/help-viewer/topnav.inc>

That would be a trivial change.

Comment 9

[Anne (:annevk)]

Can someone give feedback on that idea? It would be a trivial change to make.
I'm willing to do it.

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

cc-ing the page author.

Comment 11

[Anne (:annevk)]

Oops, I already have permission per comment 2. I will go ahead and make the change.

Comment 12

[Simon Paquet [:sipaq]]

Anne, can you verify that your changes work? They work, when I apply them
locally on my box, but not when I access the calendar homepage via my internet
connection. It might be that this is caused by the proxy that my provider is using.

I will try it again tomorrow.

Comment 13

[Anne (:annevk)]

I believe it takes a while before it gets updated because these pages are using
SSI. The included file is already updated, both in CVS and online. When you view
a page that uses the include it is not, however.

If I compare the Calendar Project Page with the Help Viewer Project Page it
should work.

Another thing, does the Calendar Project Page really need its own CSS file?

Comment 14

[Simon Paquet [:sipaq]]

Anne, 

there are probably some styles in calendar.css that aren't used anymore and
which can be removed. For the remaining styles, I'll have to see if we still
need them. If you want, take a look at calendar.css and so some cleanup, but
please post a patch here first, so that I can review it before you check it in.

Comment 15

[Anne (:annevk)]

The menu works at the moment. (However, something should be done with the style
sheets so a top LI element does not really need a nested A element. That just
sucks. It also shows that we used a:hover instead of a:link:hover, not that it
is really important and relevant to this bug.)

About calendar.css. I will try to find the cases where it is needed later and
list them so can we can see what to do with them.

Comment 16

[Simon Paquet [:sipaq]]

Ok, I removed some of the styles in calendar.css, because they were no longer
used. I searched for equivalents for the remaining styles in the site
stylesheets but couldn't find any.

I think this bug is now FIXED. Thanks for your work, Anne. Please verify, if you
agree.

Comment 17

[Anne (:annevk)]

Agreed. However, eventually we should move to no additional CSS files at all.

Also, a follow-up bug on the #nav thing should be filed. So you do not need
"<a><strong>..." to make it work.