260169 - generalize formatDateTime and formatInterval relative to given date, not just today

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: cvs-cal

dateUtils formatDateTime and formatInterval have the option to format only time
or timerange without date if formatted date is today.

These methods can be generalized so they will format only time or timerange if
formatted date is same as a relativeToDate.  This will make it easier to show
only time or time range when formatting a event in a grid box for tooltips or
printing, where the date is clear from the box.

Reproducible: Always
Steps to Reproduce:

Comment 1

[gekacheka]

Attachment: dateUtils.js patch: modify formatDateTime and formatInterval for optional relativeToDate

modify formatInterval: add optional parameter relativeToDate.
  If interval is all day 1 day on relativeToDate, produce localized "All Day".
  On other intervals within a day, relativeToDate is passed to formatDateTime.
  Simplify code to call isOnSameDate.

add isOnSameDate(date1, date2)

modify formatDateTime: change optional param omitIfToday to relativeToDate,
     where relativeToDate defaults to today if true and not a date.
  change optional param timeString to allDayOrTimeString, 
     where allDayOrTimeString defaults to localized "All Day" if true and not a
string.
  Simplify code to call isOnSameDate.

Comment 2

[gekacheka]

Attachment: Move "All Day" from calendar.properties to dateFormat.properties

Copy localized property AllDay from calendar.properties to
dateFormat.properties so it will be available to the dateFormatter in its
string bundle.	(en-US first)

(It can be removed from calendar.properties once the two places that use it are
converted to use these modified date format methods.)

Comment 3

[gekacheka]

Attachment: unifinder.js patch: call formatDateTime with isAllDay true, remove "AllDay" string

Modify formatUnifinderEventDateTime to call formatDateTime with true for the
allDayOrTimeString.  Remove lookup of localized "AllDay".

Comment 4

[Mostafa Hosseini]

Please cc me on calendar bugs you assign to yourself.

Comment 5

[Mostafa Hosseini]

All patches checked in. Thanks

Comment 6

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!