Closed Bug 260318 Opened 21 years ago Closed 21 years ago

UMR in nsScanner::AppendToBuffer

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: jst)

References

(
URL
)

Details

(Keywords: fixed-aviary1.0, fixed1.7.5)

Attachments

(1 file)

Fix.
1.17 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
chofmann
: approval-aviary+
dveditz
: approval1.7.5+
Details | Diff | Splinter Review
the field mFirstNonWhitespacePosition from bug 178088 is used uninitialized in AppendBuffer when called from the first nsScanner constructor. it is initialized in the constructor but only after the call to AppendBuffer.
Depends on: 178088
Should be a simple fix, and not fixing this will lead to unpredictable behavior...
Flags: blocking1.8a4?
Attached patch Fix. — — Splinter Review
Attachment #159628 - Flags: superreview?(bzbarsky)
Attachment #159628 - Flags: review?(bzbarsky)
Comment on attachment 159628 [details] [diff] [review] Fix. r+sr=bzbarsky
Attachment #159628 - Flags: superreview?(bzbarsky)
Attachment #159628 - Flags: superreview+
Attachment #159628 - Flags: review?(bzbarsky)
Attachment #159628 - Flags: review+
Attachment #159628 - Flags: approval1.7.x?
Attachment #159628 - Flags: approval-aviary?
Comment on attachment 159628 [details] [diff] [review] Fix. a=dveditz for 1.7.x
Attachment #159628 - Flags: approval1.7.x? → approval1.7.x+
Comment on attachment 159628 [details] [diff] [review] Fix. a=chofmann for aviary
Attachment #159628 - Flags: approval-aviary? → approval-aviary+
Fixed on trunk and on the 1.7 and aviary branches.
Status: NEW → RESOLVED
Closed: 21 years ago
Flags: blocking1.8a4?
Keywords: fixed-aviary1.0, fixed1.7.x
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: