Duplicate parameter generated in Google search

RESOLVED FIXED in Firefox1.5

Status

()

Firefox
Search
--
minor
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Ng Ming Hong, Assigned: philor)

Tracking

({fixed1.8, late-l10n, polish})

Trunk
Firefox1.5
x86
All
fixed1.8, late-l10n, polish
Points:
---
Bug Flags:
blocking1.8b5 +
blocking-aviary1.5 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10

I find that the parameter 'start' (for Google search) generated by Search
Toolbar is duplicated.

e.g. If I search for the keyword 'Meo':
http://www.google.com/search?q=Meo&start=0&start=0&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:en-US:official
I think this URL is good enough:
http://www.google.com/search?q=Meo&&start=0&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:en-US:official

Reproducible: Always
Steps to Reproduce:
1. Focus on the Search Toolbar.
2. Input any keyword and press [Enter].
3. Observe the URL generated.

Actual Results:  
Give me a duplicate parameter: 'start=0'

Expected Results:  
Each parameter should appear only once.
(Reporter)

Comment 1

13 years ago
Typo, should be:
http://www.google.com/search?q=Meo&start=0&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:en-US:official
Instead of:
http://www.google.com/search?q=Meo&&start=0&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:en-US:official

Comment 2

13 years ago
Reproduced on:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913
Firefox/0.10

The severity is too high since there is no loss of function. Should be set to minor.
(Reporter)

Comment 3

13 years ago
Changed to minor.
But I believe it just need an ultra simple fix...
Severity: normal → minor
(Reporter)

Updated

13 years ago
OS: Windows 2000 → All

Comment 4

13 years ago
I already have the fix. Just making sure this actually is a bug :)

Comment 5

13 years ago
Created attachment 159601 [details] [diff] [review]
Patch

Are there any patch guidelines?

Comment 6

13 years ago
Created attachment 159602 [details] [diff] [review]
[duplicate] Patch

Comment 7

13 years ago
Might as well change status to new.
Sorry about the spam.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

13 years ago
Attachment #159601 - Flags: review+

Comment 8

13 years ago
Comment on attachment 159601 [details] [diff] [review]
Patch

I set the wrong flag before.
Attachment #159601 - Flags: review+ → review?(p_ch)
(Reporter)

Updated

12 years ago
Flags: blocking-aviary1.1+
(Reporter)

Updated

12 years ago
Flags: blocking-aviary1.1+ → blocking-aviary1.1?

Comment 9

12 years ago
Ben, or mconnor, if this is an easy fix, can you review or land it? 
Assignee: p_ch → bugs
(Reporter)

Comment 10

12 years ago
Just as a remainder, this bug is still reproducible in Deer Park Alpha 2 (not
surprisingly).
We should fix this, and get google to update their updated .src file (once I fix
the updating searchplugins bug)

But that still doesn't make this a blocker.
Flags: blocking-aviary1.1? → blocking-aviary1.1-
Comment on attachment 159601 [details] [diff] [review]
Patch

request Ben to review (trivial)
Attachment #159601 - Flags: review?(p_ch) → review?(bugs)

Updated

12 years ago
Version: unspecified → Trunk
Attachment #159602 - Attachment description: Patch → [duplicate] Patch
Attachment #159602 - Attachment is obsolete: true
(Assignee)

Comment 13

12 years ago
Created attachment 196621 [details] [diff] [review]
fix without breaking things

There's no need to break things for either the SearchSidebar extension, or a
SeaMonkey user who somehow gets our version: when you have a single param for
previous and next, "<inputprev>" says "use the name and factor from inputnext,
but decrement it." Verified working with SeaMonkey, and working within the
limits of some bugs in SearchSidebar.

There's also no need to wait on Google changing their version: we're shipping a
plugin that claims to update from mozilla.org, and bug 306576 is going to do it
for real from addons.m.o, so there's no coordination requirement.
Assignee: bugs → bugzilla
Attachment #159601 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #196621 - Flags: review?(mconnor)
(Assignee)

Updated

12 years ago
Attachment #159601 - Flags: review?(bugs)

Updated

12 years ago
Attachment #196621 - Flags: review?(mconnor) → review+
(Assignee)

Updated

12 years ago
Keywords: polish
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox1.5
(Assignee)

Comment 14

12 years ago
Comment on attachment 196621 [details] [diff] [review]
fix without breaking things

Asking for approval without being quite sure we want it: if bug 306576 is going
to put actual content at the update urls on addons.m.o, not just do our current
404, then if we don't land this on the branch they'll get a nice bit of testing
as everyone who installs 1.5 then updates their google.src first check...
Attachment #196621 - Flags: approval1.8b5?

Updated

12 years ago
Flags: blocking1.8b5+

Comment 15

12 years ago
Comment on attachment 196621 [details] [diff] [review]
fix without breaking things

Approved for 1.8b5 per bug meeting
Attachment #196621 - Flags: approval1.8b5? → approval1.8b5+
Trunk:
Checking in browser/locales/en-US/searchplugins/google.src;
/cvsroot/mozilla/browser/locales/en-US/searchplugins/google.src,v  <--  google.src
new revision: 1.4; previous revision: 1.3
done

1.8 Branch:
Checking in browser/locales/en-US/searchplugins/google.src;
/cvsroot/mozilla/browser/locales/en-US/searchplugins/google.src,v  <--  google.src
new revision: 1.3.2.1; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8, late-l10n
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Whiteboard: [checkin needed]
A message to localizers, you probably want to take this patch for your 1.5
localizations.
As it's just a nit, I won't approve this change for the 1.0.x branch, though.

Is someone on this bug willing to take the burdon to fix the plethora of plugins
on mycroft?

A note on the google-hosted updateURL, we shouldn't put content there, as most
localizers used the same updateURL which slipped review on 1.0.x. At least we
shouldn't do that for this nit.
You need to log in before you can comment on or make changes to this bug.