260803 - Allow localization of 'Click here to get the plugin' string in content generated for missing plugin

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Pavel Franc - Mozilla.cz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10

npnul plugin contains several english string that are in corresponding resource
files:

http://lxr.mozilla.org/aviarybranch/source/modules/plugin/samples/default/windows/npnul32.rc
http://lxr.mozilla.org/aviarybranch/source/modules/plugin/samples/default/os2/npnulos2.rc
http://lxr.mozilla.org/aviarybranch/source/modules/plugin/samples/default/unix/nullplugin.h

To allow full localization of FF move them to locale dependant file and setup
the build procces to build npnul.* locale dependant


Reproducible: Always
Steps to Reproduce:
1. Use the l10n version of FF
2. Go to a page that requires missing plugin. 
3. "Click here to get the plugin" message appears

Comment 1

[Benjamin Smedberg]

This is probably WONTFIX for 1.0, and perhaps forever. The new plugin finder
service hides the null plugin by default, I think.

Comment 2

[Johnny Stenback (:jst)]

Yeah, but there's one localizable string in it too, the text "Click here to
download plugin" is static in the code. Do we care for 1.0? IMO no...

Comment 3

[Pavel Franc - Mozilla.cz]

The "Click here to get the plugin." localization problem can be also fixed by
fixing bug 83754 and moving this string into .dtd file.

Comment 4

[Johnny Stenback (:jst)]

Firefox doesn't use the default plugin any more, so bug 83754 doesn't apply to
Firefox any more.

Comment 5

[Pavel Franc - Mozilla.cz]

> Firefox doesn't use the default plugin any more, so bug 83754 doesn't apply to
> Firefox any more.

Ok. Please, clarify the summary and dependences to clearly identify this bug
with the request to be able to translate the somewhere hard-coded english
sentence that is displayed at the place of missing plugin. Thanks.

Comment 6

[Benjamin Smedberg]

http://lxr.mozilla.org/aviarybranch/source/layout/html/base/src/nsObjectFrame.cpp#1710

Comment 7

[Doron Rosenberg (IBM)]

Attachment: make the string localizable.

Comment 8

[Doron Rosenberg (IBM)]

Attachment: better patch

Comment 9

[Doron Rosenberg (IBM)]

Attachment: even better

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 160665 [details] [diff] [review]
even better

+  // get the localized text
+  nsXPIDLString missingPluginLabel;
+  missingPluginLabel = NS_LITERAL_STRING("Click here to download plugin.");
+
+  nsCOMPtr<nsIStringBundleService> stringBundleService =
+    do_GetService(NS_STRINGBUNDLE_CONTRACTID);
+
+  if (stringBundleService) {
[...]
+      rv =
stringBundle->GetStringFromName(NS_LITERAL_STRING("missingPlugin.label").get(), 
+				 getter_Copies(missingPluginLabel));
+    if (NS_FAILED(rv))
+      missingPluginLabel = NS_LITERAL_STRING("Click here to download
plugin.");
+  }

How about eliminating the duplication of the literal by changing that to
something like:

+  // get the localized text
+  nsXPIDLString missingPluginLabel;
+
+  nsCOMPtr<nsIStringBundleService> stringBundleService =
+    do_GetService(NS_STRINGBUNDLE_CONTRACTID);
+
+  if (stringBundleService) {
[...]
+      rv =
stringBundle->GetStringFromName(NS_LITERAL_STRING("missingPlugin.label").get(), 
+				 getter_Copies(missingPluginLabel));
+  }
+
+  if (!stringBundleService || NS_FAILED(rv)) {
+    missingPluginLabel = NS_LITERAL_STRING("Click here to download plugin.");
+  }

sr=jst with such a change.

Comment 11

[Doron Rosenberg (IBM)]

fixed.