260882 - cache->searchedObjectType[] should always be cleared in clear_cache()

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[kinmoz]

In clear_cache() there is a for loop that looks something like this:

    for (objectType = cachedCerts; objectType <= cachedCRLs; objectType++) {
        if (!cache->objects[objectType]) {
            continue;
        }

        ...

        cache->objects[objectType] = NULL;
        cache->searchedObjectType[objectType] = PR_FALSE;
    }

It seems that it is possible to get into the situation where
cache->objects[objectType] is NULL while cache->searchedObjectType[objectType]
is PR_TRUE.

In that particular case clear_cache() will never set the
cache->searchedObjectType[objectType] flag to PR_FALSE, which could result in
get_token_certs_for_cache() never loading the certs for new tokens that are
inserted into the slot because it thinks the certs were already cached off of
the token.

My proposed fix is to set cache->searchedObjectType[objectType] at the top of
the for loop.

Comment 1

[kinmoz]

Attachment: Patch Rev 1 (against the NSS_3_9_BRANCH)

I probably should've mentioned the file these functions live in ... doh ...
You'll find the cache functions mentioned above in
mozilla/security/nss/lib/dev/devutil.c.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 159648 [details] [diff] [review]
Patch Rev 1 (against the NSS_3_9_BRANCH)

r=nelson

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Checked in on NSS 3.9 branch for NSS 3.9.3
Checking in dev/devutil.c;  new revision: 1.23.16.1; previous revision: 1.23

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Checked in on trunk
Checking in devutil.c;  new revision: 1.25; previous revision: 1.24

Comment 5

[Wan-Teh Chang]

Comment on attachment 159648 [details] [diff] [review]
Patch Rev 1 (against the NSS_3_9_BRANCH)

r=wtc.

I reviewed create_object_array and found that
it may return NULL and set *status to PR_SUCCESS
(and *numObjects to 0).  So get_token_certs_for_cache
may set cache->objects[cachedCerts] to NULL and
cache->searchedObjectType[cachedCerts] to PR_TRUE.
Therefore clear_cache needs to handle this properly.

(Another way for a cache to get into this state is
via nssTokenObjectCache_RemoveObject, which may set
cache->objects[oType] to NULL without modifying
cache->searchedObjectType[oType].)