260980 - Clicking a link in a table make a scrollbar appear unexpectedly

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Gérard Talbot]

Clicking a link in a horizontally constrained table will create an horizontal
scrollbar unexpectedly.
Mozilla 1.8a4 build 2004092104 under XP Pro SP2 here.

The css rule involved is:
table {width: 92%; margin-left: 4%; margin-right: auto;}

If I replace "margin-right: auto;" with "margin-right: 4%;", then no scrollbar
is created when clicking the link.

Reduced testcase is coming up.

Comment 1

[Gérard Talbot]

Attachment: Minimal testcase

Just click the link.

Comment 2

[Gérard Talbot]

I have not searched for a duplicate (lack of time right now), but I intend to.

Comment 3

[Gérard Talbot]

Attachment: Better minimal testcase

Again, just click on the link.

The whole code in the attachment is:
<style type="text/css">
table {width: 92%; margin-left: 4%; margin-right: auto;}
</style>
(...)
<table><tr><td><a href="#">Some text in a link</a></td></tr></table>

Comment 4

[Bernd]

looks like an overflow issue in the outer table frame.

Comment 5

[Gérard Talbot]

Tabbing to the link also creates the horizontal scrollbar. 
Even if one neutralizes the dotted outline via 
about:config, browser.display.focus_ring_width set to 0,
it seems that the related code for outline will create an horizontal scrollbar
anyway.

Comment 6

[Bernd]

The margin computation in
http://lxr.mozilla.org/seamonkey/search?string=%3ACalculateBlockSideMargin is
sooo flawed. It returns bogus margins. There is somefixup logic inside the outer
table frame. The point of the outliner here is that it creates a style change
reflow for the inline once a link is focussed, which is handled as incr. reflow
at the outer table frame level.

Comment 7

[Bernd]

Attachment: testcase without link

Comment 8

[Ronald Tilby]

Mozilla Windows Trunk Nightly Build Regression Window
Pass: 2004071609
Fail: 2004071808

Comment 9

[Bernd]

Attachment: wip

This is the nsHTMLReflowState.cpp part of the fix. The code there is completely
broken, it will currently happily substratc NS_UNCONSTRAINEDSIZE margins and so
on. There are propably two missing parts 1. the outer table reflow somehow
learned to live with this desaster. Now if one fixes this code it blows up.
This means I need to fix the captionside code crap that I have written. 2. This
code is also used by the Block reflow and I would simply look at the regression
tests where the  problems arise.

Comment 10

[Bernd]

I dump the code now (bugzilla as patch backup system) as BC bugs have currently
a higher priority for me.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

*** Bug 253385 has been marked as a duplicate of this bug. ***

Comment 12

[Caleb]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050428
Firefox/1.0+

I can still reproduce this bug with my current build!

Comment 13

[C William Underwood]

http://www.heise.de/tp/foren/go.shtml?read=1&msg_id=10587465&forum_id=98926&showthread=1
shows the same problem, I believe.

Debian Ubuntu, using Firefox or the mozilla.org build of seamonkey, with _some_
fonts.  Focussing on 'ja mann', 'Das ist es!' or 'du laberst Müll' causes them
to immediately wrap;  setting the about:config variable mentioned above stops
that from happening.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Fixed by the reflow branch checkin.