261145 - nsPrintfCString should not truncate long result strings

Status: RESOLVED DUPLICATE of bug 743056

(Core :: XPCOM, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The (const char *format, ...) nsPrintfCString constructor is almost entirely
worthless -- it initializes the internal buffer to the default string size (16
bytes), and then calls PR_snprintf with that fixed size.  It would be much more
useful and would make more sense if it were to calculate the amount of space
needed for the formatted string and DTRT.

Comment 1

[Darin Fisher]

it would be nice if we could avoid heap allocations in every invocation, but
maybe that's just what we should do :-/

of course when given a size argument, it should continue to truncate.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I thought I filed a bug somewhere on making it us PR_smprintf and having a
PrintfString that uses nsTextFormatter (not nsTextFormater! :-).

Comment 3

[:Cykesiopka]

IIUC, the landed patch in Bug 743056 should have fixed this.
Feel free to re-open if this is not the case.