261210 - bz_secure css not useful for text based browsers. Lynx/JAWS

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Jason Pyeron]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier: lynx

Need a notation for text based browser that aa bug is "secure"
suggested patch to follow.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Jason Pyeron]

Attachment: adds an astrisk for non css type browsers

Comment 2

[Jason Pyeron]

issue spawned from work on bug 260411

Comment 3

[Christian Reis]

Isn't a single asterisk, no hints, a bit undiscoverable?

Comment 4

[Jason Pyeron]

Attachment: now with extra flavor

Comment 5

[Jason Pyeron]

I do not have a "great" idea where to put the caption, so I put it with the 
table header, maybe it should go with the footer.

BTW: the text and astrisk 'should' not show in css capable browses
i.e. style="display: none"

Comment 6

[Jason Pyeron]

Attachment: note at bottom

bit rot in under an hour, I'm impressed

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 159905 [details] [diff] [review]
note at bottom

>+      <span style="display: none">[%+ '*' IF bug.secure_mode %]</span>

Some text label equivalent to the icon would be better than the generic
asterisk, even if it took up more space, since it would explain what it
signifies on the spot rather than in some possibly far away corner of the page
(for secure bugs this is fairly important).  I'm thinking of something like
[SECURE] or an abbreviated equivalent like [SEC].

Also, note that in the past we didn't mark bugs secure on installations that
secure all bugs by default.  I forget exactly how we determined this, but I
think it had to do with the usebuggroups parameter.  I'm not sure if the new
security icon does this, but it should, as should this textual equivalent,
since marking bugs secure doesn't make sense for that kind of installation.

Incidentally, where does "secure_mode" come from?  I don't find it in the
Bugzilla source code.

Comment 8

[Jason Pyeron]

> Incidentally, where does "secure_mode" come from?  I don't find it in the
> Bugzilla source code.

Don't know, but it changed a few hours ago.

[pyerotechnics@ns projects]$ cvs diff -u -r 1.17 -r 1.18 
template/en/default/list/table.html.tmpl
Index: template/en/default/list/table.html.tmpl
===================================================================
RCS 
file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmp
l,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- template/en/default/list/table.html.tmpl    23 Aug 2004 15:21:58 -0000      
1.17
+++ template/en/default/list/table.html.tmpl    23 Sep 2004 19:05:20 -0000      
1.18
@@ -152,7 +152,8 @@
              bz_[% bug.priority FILTER css_class_quote %]
              bz_[% bug.bug_status FILTER css_class_quote %]
              [%+ "bz_$bug.resolution" FILTER css_class_quote IF bug.resolution 
%]
-             [%+ "bz_secure" IF bug.isingroups %]
+             [%+ "bz_secure" IF bug.secure_mode %]
+             [%+ "bz_secure_mode_$bug.secure_mode" FILTER css_class_quote IF 
bug.secure_mode %]
              [%+ count % 2 == 1 ? "bz_odd" : "bz_even" %]
              ">

Comment 9

[Jason Pyeron]

Attachment: [SEC] v1.06

okay I think I have it...

 65 bugs found.

 ID Sev Pri Plt Assignee Status Resolution Summary
 2 [SEC] nor P2 PC [e-mail] ASSI Adobe Acrobat index file
configuration
 3 [SEC] nor P2 PC [e-mail] ASSI ISAPI / IIS Authentication
 5 [SEC] nor P2 PC [e-mail] ASSI jsp quiries in the database
 10 [SEC] blo P2 All [e-mail] NEW dbwritesallowed() in
Bugzilla.java
 11 [SEC] blo P1 All [e-mail] NEW getConnection() is not done!

 12 [SEC] blo P2 All [e-mail] NEW getUser() is not done!
 13 [SEC] min P2 PC [e-mail] NEW Salt for crypt is not Crypto
Random
 14 [SEC] blo P2 All [e-mail] NEW getGroups() is not done
 15 [SEC] cri P2 All [e-mail] NEW need to address UserInGroup
function called from Query.<I...
 16 [SEC] blo P1 All [e-mail] NEW finish PulldownBox in
Query.LineSummary
 26 [SEC] nor P2 N/A [e-mail] ASSI Closet light fixture
 105 [SEC] nor P3 PC [e-mail] UNCO test
 110 nor P3 PC [e-mail] ASSI TAPI modem selection
 111 nor P3 PC [e-mail] ASSI Brainstorm on parse input
 112 nor P3 PC [e-mail] NEW Get the joystick to speak each move
it makes.
 113 nor P3 PC [e-mail] NEW Enable Jeff to select a phone
number and initiate a phone...
 114 nor P3 PC [e-mail] NEW Enable Jeff to dial digits during a
phone call so he can ...
 press space for next page --

Comment 10

[Jason Pyeron]

i really wanted to use an ALT for the padlock, but it is implimented as a 
background image.

ALSO if it stays as a CSS add in then back to square ONE.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 159919 [details] [diff] [review]
[SEC] v1.06


> i really wanted to use an ALT for the padlock, but it is implimented as a 
> background image.

Presumably it's a background image for a reason, but if you can convert it to a
regular image while still maintaining its functionality, then go for it. 
Confer with Kiko first, though, as he'll know if it needs to stay a background
image for some reason.

My only nit is that the text markers appear to the right of bug IDs, whereas
the padlock icons appear to the left.  These should ideally be consistent.

Otherwise looks good. r=myk

Comment 12

[Jason Pyeron]

someone with cvs access come and sweep me away....
or do i need approval2.18 first?

Comment 13

[Dave Miller [:justdave]]

The code this is touching doesn't exist in the 2.18 branch (the padlock was new
in 2.19) so no need for 2.18 approval.

Comment 14

[Vlad Dascalu]

Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.19; previous revision: 1.18
done

Comment 15

[Christian Reis]

Dave, the padlock *is* in 2.18.

Comment 16

[Dave Miller [:justdave]]

(In reply to comment #15)
> Dave, the padlock *is* in 2.18.

It is?  OK, well then by all means let's get this in :)

Comment 17

[Vlad Dascalu]

Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.16.2.2; previous revision: 1.16.2.1
done