261593 - get rid of AssignWithConversion in filesystemdatasource

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 160092 [details] [diff] [review]
patch

- most of the patch is correct because GetValueConst returns UTF-8, as
described in nsIRDFResource.idl

- the beos part is correct because UTF-8 is beos's native encoding

Comment 3

[Axel Hecht]

I'd rather see us fixing the string usage here right, this is just wallpapering
over one issue.
Why not use 
nsCString uri;
rv = source->GetValueUTF8(uri); // this just refcounts the buffer
if (NS_FAILED(rv)) return(rv);

NS_ConvertUTF8toUTF16 theURI(uri);

This seems to do, up to not doing an additional string length check, the exact
same thing.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v3

fully addresses review comment

Comment 6

[Axel Hecht]

Comment on attachment 160647 [details] [diff] [review]
patch  v3

r=[e-mail]

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in rdf/datasource/src/nsFileSystemDataSource.cpp;
/cvsroot/mozilla/rdf/datasource/src/nsFileSystemDataSource.cpp,v  <-- 
nsFileSystemDataSource.cpp
new revision: 1.137; previous revision: 1.136
done