261671 - Simplify and improve Bugzilla Helper

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Gervase Markham [:gerv]]

Here are some of the ideas suggested recently that I want to implement:

- Warn severely about filing bugs in anything other than the latest release, 
  checked by UA

- Better set the expectations of people filing UNCO bugs 

- Have much less text

- Change the search people do before filing bugs to search all bugs
  (including resolved ones) filed in the last two months.

I also plan to clean up, shorten and clarify the text.

Comments on these ideas welcome.

Gerv

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Your plan sounds good; let's see the patch!

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

OK, this does everything except the UA checking, which I didn't have time to
implement.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Hmm. I can't ask for reviews in this product.

Myk: can you review this, and (in my absence) get it applied to b.m.o, the 2.19
trunk, or wherever you think appropriate?

It's a 2.19 patch, but I doubt create-guided.html.tmpl has changed much since
the fork.

Gerv

Comment 4

[Myk Melez [:myk] [@mykmelez]]

I shall endeavour to get this reviewed and applied in time for the Firefox 1.0
release.

Comment 5

[Gervase Markham [:gerv]]

Moving to Bugzilla product so I can make this block 2.18, get it into the 2.18
branch, and thereby get it onto b.m.o. :-)

Gerv

Comment 6

[Gervase Markham [:gerv]]

The patch applies perfectly to both 2.18 and the trunk - the file hasn't been
modified since the branch was created.

Gerv

Comment 7

[Gervase Markham [:gerv]]

Removing 2.18 requests - I didn't realise b.m.o. was moving to the tip.

I'd still like review though, please, guys :-)

Gerv

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 163741 [details] [diff] [review]
Patch v.1

>-    This is a template used on mozilla.org - it, along with the
>-    comment-guided.txt.tmpl template, are included as a demo of what it's
>+    This is a template used on mozilla.org. It, along with the
>+    comment-guided.txt.tmpl template which formats what this form returns, 
>+    are included as a demo of what it's

Nit: this is awkward, suggest instead:

This is a template used on mozilla.org.  This template, and the
comment-guided.txt.tmpl template that formats the data submitted via the form
in this template, ...


>-    <a href="http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/latest/">Mozilla</a>,
>-    <a href="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/">Firefox</a> or
>-    <a href="http://ftp.mozilla.org/pub/mozilla.org/camino/nightly/latest/">Camino</a>
>+    <a href="http://www.mozilla.org/releases/">one of our products</a>

Besides not listing Firefox and Thunderbird, mozilla.org/releases/ only lists
releases, and we want to drive users to the latest nightly to reduce duplicates
of fixed bugs, so this should continue to point users to the latest/
directories.


>+  <font color="red">Please don't skip this step - 50% of bugs filed are reported
>+  already.</font>

Nit: suggest "half of all bugs filed" instead of "50% of bugs filed" for more
impact.


>+[%# Include other products if sensible %]
>+[% IF product == "Firefox" %]
>+  [% productstring = "product=Browser&amp;product=Firefox" %]
>+[% ELSIF product == "Thunderbird" %]
>+  [% productstring = "product=MailNews&amp;product=Thunderbird" %]

Browser and MailNews are now both "Mozilla Application Suite" I believe.


>-    <td align="right" valign="middle">
>+    <td align="right" valign="top">

These are better as valign="baseline".


>+        <b>IMPORTANT</b>: problems with broken web pages go
>+        <a href="http://write-this-webtool/">in this form instead</a>.

This should be reverted until the tool is ready.


>-<h3>Step 3 - submit the [% terms.bug %]</h3>
>+<h3>Step 3 of 3 - submit the [% terms.bug %]</h3>

Nit: "submit the bug *report*" would make a bit more sense.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

I wonder if we should remove "blocker" from the list of possible severities,
since users who get the guided form are unlikely to know whether Bugzilla
developers are blocked on the bug being submitted.  Then again, it probably
doesn't matter unless there are problems with too many bugs being filed as blockers.

Comment 10

[Gervase Markham [:gerv]]

Attachment: Patch v.2

All changes made, apart from the valign change - it really looked ugly on the
multi-line text boxes when I did that. 

We seem to have missed the upgrade boat. Can this get in with any post-upgrade
fixes that we do?

Gerv

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 168685 [details] [diff] [review]
Patch v.2

Looks good, r=myk.  This is low risk, so we should be able to get it onto
b.m.o.

Comment 12

[Dave Miller [:justdave]]

Get it checked in.  There's been a number of regressions fixed this last week,
so I'm probably going to pull CVS again to pick them up on b.m.o sometime in the
next week.

Comment 13

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v
 <--  create-guided.html.tmpl
new revision: 1.20; previous revision: 1.19
done

Gerv

Comment 14

[Gervase Markham [:gerv]]

This briefly set Tinderbox on fire; now fixed.

Gerv