261722 - Find as you type should not activate on gmail keyboard shortcuts

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Jon Suen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040922 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040922 Firefox/0.10

Using gmail keyboard shortcuts causes find-as-you-type toolbar to activate, even
across actions, such as opening a new message. I believe that this is a
regression, as pre-toolbar find as you type did not do this.

Reproducible: Always
Steps to Reproduce:
1. Enable gmail keyboard shortcuts
2. In Inbox view press "o"


Actual Results:  
Find-as-you-type activates. Gmail also opens selected message correctly.

Expected Results:  
Find-as-you-type does not activate, Gmail also opens selected message.

Comment 1

[Nickolay_Ponomarev]

confirming with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

(this works with mozilla's fayt, though:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041008)

Comment 2

[Blake Ross]

One line patch to check if default was prevented:

Index: content/findBar.js
===================================================================
RCS file: /cvsroot/mozilla/toolkit/components/typeaheadfind/content/Attic/findBa
r.js,v
retrieving revision 1.1.2.8
diff -u -r1.1.2.8 findBar.js
--- content/findBar.js  16 Oct 2004 23:43:03 -0000      1.1.2.8
+++ content/findBar.js  17 Oct 2004 11:35:04 -0000
@@ -327,7 +327,7 @@

 function shouldFastFind(evt)
 {
-  if (evt.ctrlKey || evt.altKey || evt.metaKey)
+  if (evt.ctrlKey || evt.altKey || evt.metaKey || evt.getPreventDefault())
     return false;

   var elt = document.commandDispatcher.focusedElement;