The following list of files are included in the .cvsignore file for their directory, but are actually kept under source control, and pulled and built as part of the build process. This means that: - It's not possible to change these files without fixing .cvsignore because CVS won't check them in - Any attempt to cvs import a checked-out copy of NSS into another CVS tree excludes these files and therefore NSS won't build when checked out of the new tree. This is due to cvs import -I ! still respecting .cvsignore - see the notes about the -I option here: https://www.cvshome.org/docs/manual/cvs-1.11.17/cvs_18.html#SEC178 If these files should not actually be in .cvsignore, they should be removed. mozilla/security/nss/lib/ckfw/builtins: certdata.c mozilla/security/nss/lib/ckfw: nssck.api mozilla/security/nss/lib/ckfw: nssckepv.h mozilla/security/nss/lib/ckfw: nssckft.h mozilla/security/nss/lib/ckfw: nssckg.h mozilla/security/nss/lib/pki1: oiddata.c mozilla/security/nss/lib/pki1: oiddata.h Gerv
"If these files should not actually be in .cvsignore, they should be removed." To clarify: they should be removed from .cvsignore, not removed from the tree :-) Gerv
Gerv: We already cvs removed mozilla/security/nss/lib/ckfw/builtins/.cvsignore on 2004/05/17. I can cvs remove mozilla/security/nss/lib/ckfw/.cvsignore and mozilla/security/nss/lib/pki1/.cvsignore. They only contain files that should not be cvs ignored. Would you like me to do that?
Status: NEW → ASSIGNED
Created attachment 160242 [details] [diff] [review] Proposed patch: cvs remove the unnecessary .cvsignore files
Comment on attachment 160242 [details] [diff] [review] Proposed patch: cvs remove the unnecessary .cvsignore files Wan-Teh: sounds good. I discovered this problem on the Aviary branch (which was cut three days before you fixed that other file), although I suspect you won't want to bother fixing the others there. Gerv
Attachment #160242 - Flags: review?(gerv) → review+
Fixed on the NSS tip (NSS 3.10). Removing ckfw/.cvsignore; /cvsroot/mozilla/security/nss/lib/ckfw/.cvsignore,v <-- .cvsignore new revision: delete; previous revision: 1.1 done Removing pki1/.cvsignore; /cvsroot/mozilla/security/nss/lib/pki1/.cvsignore,v <-- .cvsignore new revision: delete; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.10
Setting priorities on unprioritized bugs resolved fixed for NSS 3.10.
Priority: -- → P2
Version: unspecified → 3.9
You need to log in before you can comment on or make changes to this bug.