261811 - New window toolbar has multiple problems

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Chris Cook]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040927 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040927 Firefox/0.10

When a new window is opened with no toolbars, the new static toolbar with the
urlbar has multiple problems.

The biggest problem is that if the urlbar has been moved to another toolbar then
it is not displayed in the new window.

The next problem is that toolbar customization is allowed. Customization should
be disabled for toolbars when the window is in this mode.

The third problem is that, while toolbar buttons are hidden, toolbar separators
not not hidden. Perhaps toolbar separators should be given a class of
"chromeclass-toolbar-additional" like toolbar buttons have so that it will be
properly hidden. An alternative, but less elegant, possibility is to add a
selector to /global/content/xul.css for these separators.

Reproducible: Always
Steps to Reproduce:
1. View > Toolbars > Customize
2. Move "Location" urlbar to the "Bookmarks Toolbar."
3. Place some separators on the "Navigation Toolbar."
4. Exit toolbar customization.
5. In the browser, click a link which opens a new window with toolbars disabled
(e.g., gmail contacts).
6. Notice that the toolbar is visible but the "Location" urlbar is missing.
7. Right-click toolbar and notice that it is customizable.
8. Notice that the toolbar separators are visible.

Comment 1

[Chris Cook]

Setting to block 1.0 (hopefully)

Comment 2

[Chris Cook]

I don't know if it is related, but another problem is that the tab bar is
visible in these new windows.

Comment 3

[Volkmar W. Pogatzki]

(In reply to comment #0)
> The biggest problem is that if the urlbar has been moved to another toolbar 
> then it is not displayed in the new window.

In any case I'm used to putting the urlbar up into the menubar and I never saw
that problem except in fullscreen mode.

> 
> The next problem is that toolbar customization is allowed. Customization 
> should be disabled for toolbars when the window is in this mode.

That way it would become impossile to re-customize the urlbar back into  the
navigation toolbar. Or not?

Comment 4

[Chris Cook]

(In reply to comment #3)
> That way it would become impossile to re-customize the urlbar back into  the
> navigation toolbar. Or not?

It is my assumption that when a window is opened in this mode (with a
"chromehidden" attribute) that the toolbar is presented ONLY to display a
readonly address of the current window. Further, while toolbar customization is
enabled, moving things around does not affect anything in the current window.
You would have to open a new normal window to see the customization changes.
Therefore, customization really should not be allowed in this mode.

Comment 5

[Peter van der Woude [:Peter6]]

-> -1.0
->New

per bsmedberg

moving the urlbar gives some more problems
see bug 248002

Comment 6

[Chris Cook]

Attachment: Patch to add separators, space, and springs to xul.css

This patch adds the separator, space, and spring widgets to the list of items
to be hidden when window[chromehidden~="toolbar"].

Comment 7

[Chris Cook]

Attachment: Patch to add "chromeclass-toolbar-additional" class to toolbar elements

This patch adds the "chromeclass-toolbar-additional" class to separator, space,
and spring elements so that it will be correctly hidden when
window[chromehidden~="toolbar"].

Comment 8

[Chris Cook]

Attachment: Patch to add "chromeclass-toolbar-extrachrome" class to toolbar elements

This patch adds a new "chromeclass-toolbar-extrachrome" class to the separator,
space, and spring elements. It also adds this class to the list of elements in
xul.css to be hidden when window[chromehidden~="toolbar"]. I made up this new
class so it may need to be changed to something else.

The 3 patches I have submitted are all mutually exclusive. They are simply
different solutions for the third problem I discussed initially. They all hide
the separator and space elements in the toolbar of popup windows. I created all
three patchs because I was unsure which was the ideal solution.

Comment 9

[Chris Cook]

Can someone review these patches? It would be nice to at least have one of these
problems fixed for 1.0.

Comment 10

[Ryan Polk (Quark)]

Comment on attachment 160972 [details] [diff] [review]
Patch to add separators, space, and springs to xul.css

You don't set review+ to request reviews, you set ? and ask a relevant review.

Asking Ben b/c I don't know who else would handle this area.

Comment 11

[Phil Ringnalda (:philor)]

--> INVALID, removing the static urlbar for popups rather neatly fixed its
problems (long, long ago).

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 160972 [details] [diff] [review]
Patch to add separators, space, and springs to xul.css

Clearing obsolete request.

Comment 13

[Phil Ringnalda (:philor)]

Comment on attachment 160973 [details] [diff] [review]
Patch to add "chromeclass-toolbar-additional" class to toolbar elements

Clearing obsolete request.

Comment 14

[Phil Ringnalda (:philor)]

Comment on attachment 160974 [details] [diff] [review]
Patch to add "chromeclass-toolbar-extrachrome" class to toolbar elements

Clearing obsolete request.