261847 - Seach plug-ins Update Mechanism Not Working

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Rafael Ebron (:rebron)]

Code from: amazondotcom.src

<BROWSER
        update="http://www.mozilla.org/products/firefox/plugins/amazondotcom.src"
       
updateIcon="http://www.mozilla.org/products/firefox/plugins/amazondotcom.png"
        updateCheckDays="3"
	>
The browser needs to check code from the search plug-in in the local store and
pull from the server based on updateCheckDays parameter and update as necessary.

Not sure if this is a client or server issue.

Comment 1

[Rafael Ebron (:rebron)]

marking as + per Ben.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

1 - correct string usage
2 - validate engines used for GetInternetSearchURL too - this basically checks
to see if the update interval has expired and we need to check for updates.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 161453 [details] [diff] [review]
patch

>Index: xpfe/components/search/src/nsInternetSearchService.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/components/search/src/nsInternetSearchService.cpp,v
>retrieving revision 1.207.6.5
>diff -p -u -8 -r1.207.6.5 nsInternetSearchService.cpp
>--- xpfe/components/search/src/nsInternetSearchService.cpp	8 Oct 2004 00:56:31 -0000	1.207.6.5
>+++ xpfe/components/search/src/nsInternetSearchService.cpp	8 Oct 2004 08:29:47 -0000
>@@ -2642,17 +2642,19 @@ InternetSearchDataSource::GetInternetSea
[...]
> 	if (!engine)	return(NS_ERROR_UNEXPECTED);
> 
>-	// if its a engine from a search category, then get its "#Name",
>+  validateEngine(engine);
>+  
>+  // if its a engine from a search category, then get its "#Name",

Indentation is horked here; file seems to use hard tabs.

r=[e-mail] with indentation change

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 161453 [details] [diff] [review]
patch

sr=me -- indentation in rjc code is a trail of tears, to be mopped up after
aviary 1.0, on the trunk.

/be

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 161453 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

fixed br & trunk