Seach plug-ins Update Mechanism Not Working

RESOLVED FIXED

Status

()

Firefox
Search
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: rebron, Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

({fixed-aviary1.0})

1.0 Branch
x86
All
fixed-aviary1.0
Points:
---
Bug Flags:
blocking-aviary1.0 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
Code from: amazondotcom.src

<BROWSER
        update="http://www.mozilla.org/products/firefox/plugins/amazondotcom.src"
       
updateIcon="http://www.mozilla.org/products/firefox/plugins/amazondotcom.png"
        updateCheckDays="3"
	>
The browser needs to check code from the search plug-in in the local store and
pull from the server based on updateCheckDays parameter and update as necessary.

Not sure if this is a client or server issue.
(Reporter)

Updated

14 years ago
Flags: blocking-aviary1.0?
OS: Windows XP → All
(Reporter)

Comment 1

14 years ago
marking as + per Ben.
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Created attachment 161453 [details] [diff] [review]
patch

1 - correct string usage
2 - validate engines used for GetInternetSearchURL too - this basically checks
to see if the update interval has expired and we need to check for updates.
Comment on attachment 161453 [details] [diff] [review]
patch

>Index: xpfe/components/search/src/nsInternetSearchService.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/components/search/src/nsInternetSearchService.cpp,v
>retrieving revision 1.207.6.5
>diff -p -u -8 -r1.207.6.5 nsInternetSearchService.cpp
>--- xpfe/components/search/src/nsInternetSearchService.cpp	8 Oct 2004 00:56:31 -0000	1.207.6.5
>+++ xpfe/components/search/src/nsInternetSearchService.cpp	8 Oct 2004 08:29:47 -0000
>@@ -2642,17 +2642,19 @@ InternetSearchDataSource::GetInternetSea
[...]
> 	if (!engine)	return(NS_ERROR_UNEXPECTED);
> 
>-	// if its a engine from a search category, then get its "#Name",
>+  validateEngine(engine);
>+  
>+  // if its a engine from a search category, then get its "#Name",

Indentation is horked here; file seems to use hard tabs.

r=vladimir@pobox.com with indentation change
Attachment #161453 - Flags: review+
Comment on attachment 161453 [details] [diff] [review]
patch

sr=me -- indentation in rjc code is a trail of tears, to be mopped up after
aviary 1.0, on the trunk.

/be
Attachment #161453 - Flags: superreview+

Comment 5

14 years ago
Comment on attachment 161453 [details] [diff] [review]
patch

a=asa for aviary checkin.
Attachment #161453 - Flags: approval-aviary+
fixed br & trunk
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Updated

14 years ago
Keywords: fixed-aviary1.0
You need to log in before you can comment on or make changes to this bug.