Closed
Bug 261911
Opened 20 years ago
Closed 15 years ago
about:buildconfig should be localizable through .dtd file
Categories
(Firefox Build System :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
WONTFIX
Future
People
(Reporter: p.franc, Unassigned)
References
()
Details
Attachments
(2 files)
9.60 KB,
patch
|
benjamin
:
review-
|
Details | Diff | Splinter Review |
18.11 KB,
patch
|
benjamin
:
review+
benjamin
:
approval-aviary1.1a2-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.7) Gecko/20040803 Firefox/0.9.3
This is a split of bug 257375.
Piotr Komoda <gorky@neo.pl> reported
Having translated about:mozilla and about:buildconfig pages requires from us
(localizers) to "hack" toolkit.jar and change mozilla.xhtml and buildconfig.html
in \global. Now, when the whole build process of localized official releases is
covered by mozilla.org, we can't do this modification. Besides, even draft of
trademark policy doesn't allow us to do so. The easiest way to solve the
problem and (by the way) to make L10n teams life easier is to let us translate
contents of those abouts via .dtd or .properties files, just like in
about:plugins case....
And Benjamin Smedberg <bsmedberg@covad.net> commented
So I'm happy to create a patch for about:mozilla (it's mostly done in my tree),
but about:buildconfig isn't going to happen (besides, if you're geeky enough to
read about:buildconfig, you're gonna have to know the English word for
"compiler" anyway).
Reproducible: Always
Steps to Reproduce:
Reporter | ||
Comment 1•20 years ago
|
||
IMHO this is still valid l10n bug.
Please don't close it. Just consider it as a WONTFIX for 1.0, assigne it to
nobody@mozilla.org and mark it as NEW for post 1.0 developement.
Comment 2•20 years ago
|
||
You make the patch, or find a volunteer. I'm not wasting my time on something
like this which is not part of the Firefox UI.
Assignee: bryner → p.franc
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
QA Contact: asa → bsmedberg
Target Milestone: --- → After Firefox 1.0
Version: unspecified → Trunk
Comment 3•20 years ago
|
||
CCing Gandalf. Maybe he will try to make the patch...
Reporter | ||
Comment 4•20 years ago
|
||
Comment 5•20 years ago
|
||
Comment on attachment 172570 [details] [diff] [review]
Replace buildconfig.html with buildconfig.xhtml
This will break seamonkey without changes to xpfe/ as well.
Attachment #172570 -
Flags: review-
Comment 6•20 years ago
|
||
just added xpfe version of buildconfig. File buildconfig.dtd is duplicated in
xpfe/global/resources/locale and toolkit/locales, but so was
buildconfig.html.in in xpfe/global and toolkit/content, so I hope it should not
be problem.
Attachment #187213 -
Flags: review?(benjamin)
Comment 7•20 years ago
|
||
Comment on attachment 187213 [details] [diff] [review]
buildconfig.xhtml in toolkit and xpfe
r=me, but this is *not* approved for the 1.8 cycle, it must wait for 1.9 to
open (i.e. this will not be in Firefox 1.1).
Attachment #187213 -
Flags: review?(benjamin)
Attachment #187213 -
Flags: review+
Attachment #187213 -
Flags: approval-aviary1.1a2-
Comment 8•19 years ago
|
||
Patch still works with current trunk.
Comment 9•19 years ago
|
||
Maybe it would be an idea to add some id attributes around the XHTML to make it easier (and more reliable) to parse?
Comment 10•19 years ago
|
||
Really, nobody ought to be parsing about:buildconfig... if you need the information in it, we ought to provide an API for getting that information (and bugs are filed on that).
Updated•18 years ago
|
QA Contact: benjamin → build.config
Reporter | ||
Updated•15 years ago
|
Assignee: p.franc → nobody
Comment 11•15 years ago
|
||
Since about:support has a link to about:buildconfig, I think this page should be localized as well as it's about:support or about:plugins (it's linked from ab:support too)
Ideas?
Comment 12•15 years ago
|
||
I'm not sold on the idea that translating about:buildconfig helps support.
Talking about modifications to about:buildconfig, it'd be nice to have the localization source info in it, and for multi-repo apps, the revisions of the app repos in addition to the toolkit one.
Comment 13•15 years ago
|
||
I really don't think we should spend localizer time on this file, and this bug should be WONTFIX. I don't know whether multi-repo apps/l10n repo IDs, etc would be possible, but it should be a different bug in any case.
Comment 14•15 years ago
|
||
Sounds good. The comm-central etc bits are covered by bug 456360.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•