261957 - Install script template for other locales never register DOMI or HELP (even when they are present)

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Vincent Béron]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.2) Gecko/20040808
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.2) Gecko/20040808

The ab-CD.jst files in browser/installer/{unix,windows}/ab-CD.jst (used as
templates for the install.js in the langpack xpi for the full installer) never
register DOMI or HELP, even if LOCALE_HAS_DOMI or LOCALE_HAS_HELP is set in
defines.inc.
The install.rdf template in browser/locales/generic/install.rdf (for standalone
xpi as extensions) do have those checks.
Fix: add checks for LOCALE_HAS_DOMI and LOCALE_HAS_HELP to ab-CD.jst.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Vincent Béron]

Attachment: Add checks for LOCALE_HAS_DOMI and LOCALE_HAS_HELP in ab-CD.jst

Comment 2

[Vincent Béron]

Comment on attachment 160361 [details] [diff] [review]
Add checks for LOCALE_HAS_DOMI and LOCALE_HAS_HELP in ab-CD.jst

Requesting review from bsmedberg

Comment 3

[Simon Paquet [:sipaq]]

This should go to bsmedberg

Comment 4

[Benjamin Smedberg]

Comment on attachment 160361 [details] [diff] [review]
Add checks for LOCALE_HAS_DOMI and LOCALE_HAS_HELP in ab-CD.jst

Please do not ifdef autoconfig. That ifdef in toolkit/ is a temporary measure
for thunderbird, autoconfig is considered an essential part of firefox.

You need to fix up the makefile that builds these also, because right now it
does not include defines.inc. See
http://lxr.mozilla.org/aviarybranch/source/browser/installer/windows/Makefile.i
n#91
which needs the -I flag from
http://lxr.mozilla.org/aviarybranch/source/browser/installer/unix/Makefile.in#8
5

Comment 5

[Vincent Béron]

Attachment: Add checks for LOCALE_HAS_DOMI and LOCALE_HAS_HELP in ab-CD.jst (take 2)

Comment 6

[Vincent Béron]

Comment on attachment 160365 [details] [diff] [review]
Add checks for LOCALE_HAS_DOMI and LOCALE_HAS_HELP in ab-CD.jst (take 2)

Review points taken into account.
Requesting review from bsmedberg for revised patch

Comment 7

[Benjamin Smedberg]

Fixed on branch, doesn't apply (yet) to the trunk.