261973 - use nsRefPtrHashtable, and store nsDownload in it

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

to avoid having to cast, and to remove the need for nsStringKey.

this is part of unifying seamonkey/toolkit dl manager backends.

the PRUnichar* -> AString changes are due to nsStringHashKey's requirements

the if (mInner) changes are just a merge from a seamonkey patch

the move of the pause functions are done so that they are at the same place of
the file as in seamonkey.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

does this patch need any updating to be brought to the trunk? 

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

(by that I mean up to date)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

ah... probably. I do believe there were some changes to this code since I made that patch.

Comment 5

[Steffen Wilberg]

Comment on attachment 160383 [details] [diff] [review]
patch

This has bitrotted even more in the meantime.
And Ben doesn't do reviews anymore, so removing obsolete review request.

Comment 6

[Shawn Wilsher :sdwilsh]

now using an nsCOMArray with sqlite back-end.