261998 - onbeforeunload should not apply to internal anchors

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Mike Caines]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

If an assigned onbeforeunload event handler 'cancels' the event, clicking on an
anchor which has an href referencing an element id, results in the dialog which
asks the user to confirm navigating away from the page. IEWin does not exhibit
this behaviour.

Reproducible: Always
Steps to Reproduce:
1. See testcase
2. Click the 'go to foo' link.

Actual Results:  
Confirm dialog is shown.

Expected Results:  
Confirm dialog is not shown.

Comment 1

[Mike Caines]

Attachment: Testcase

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

also seen on linux, current cvs (trunk)

Comment 3

[Johnny Stenback (:jst)]

Attachment: Fix.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 160426 [details] [diff] [review]
Fix.

r+sr=bzbarsky

Comment 5

[Johnny Stenback (:jst)]

Fix checked in on the trunk.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 160426 [details] [diff] [review]
Fix.

Low-hanging fruit that's probably worth taking on the branches as
onbeforeunload events will get more popular as developers discover them.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 160426 [details] [diff] [review]
Fix.

a=asa for branches checkin.

Comment 8

[Johnny Stenback (:jst)]

Fixed on branches.