Closed Bug 262126 Opened 19 years ago Closed 19 years ago

Invalid date parsing with MySQL 4.1

Categories

(Bugzilla :: Bugzilla-General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: goobix, Assigned: goobix)

Details

Attachments

(1 file)

I get:

[Wed Sep 29 18:27:02 2004] show_bug.cgi: Date/Time format (2004-09-29 16:47:43)
unrecogonzied at Bugzilla/Util.pm line 169.

By looking at the source it seems we expect 2004.09.29; I guess 2004-09-29
appears on my system as a combination of local settings and the newer MySQL that
I'm using; it makes sense to add the format to Bugzilla/Util.pm as well?
Flags: blocking2.20?
Flags: blocking2.18?
Flags: blocking2.16.7?
Assignee: justdave → vladd
Attached patch V1Splinter Review
Attachment #160618 - Flags: review?(kiko)
Comment on attachment 160618 [details] [diff] [review]
V1

I don't see why this would be a problem. I already had this problem before and
added exactly the same hack as you.
Attachment #160618 - Flags: review?(kiko) → review+
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval2.18?
Flags: approval2.16?
seems to me like we had DATE_FORMAT specifically requesting the times be
returned from the database with periods (for the DB compatibility stuff, since
certain other databases can ONLY do it that way).

The correct fix for this would be to find the broken or missing DATE_FORMAT calls.
but that's something to do in 2.22, since we don't have DB compatibility yet
anyway :)

I don't believe this affects 2.16...  Bugzilla/Util.pm doesn't exist. :)
Flags: blocking2.20?
Flags: blocking2.20+
Flags: blocking2.18?
Flags: blocking2.18+
Flags: blocking2.16.7?
Flags: blocking2.16.7-
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval2.16?
Flags: approval2.16-
Flags: approval+
Whiteboard: patch awaiting checkin
Target Milestone: --- → Bugzilla 2.18
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.13; previous revision: 1.12
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.12.2.1; previous revision: 1.12
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: patch awaiting checkin
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.