Closed Bug 262238 Opened 20 years ago Closed 20 years ago

Add an explaining comment to mail.identity.default.bcc_*

Categories

(MailNews Core :: Composition, defect)

Product:
MailNews Core
Component:
Composition
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Stefan.Borggraefe, Assigned: mcsmurf)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

Add a explaining comment
979 bytes, patch
Bienvenu
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
Assignee: sspitzer → mcsmurf
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 160634 [details] [diff] [review]
Patch

Nope, i think this is the wrong patch :), take a look at
http://lxr.mozilla.org/mozilla/source/mailnews/base/util/nsMsgIdentity.cpp#480
and the following line. It seems they just forgot  to put the right pref name
in the code, it gets  the pref via
http://lxr.mozilla.org/mozilla/source/mailnews/base/util/nsMsgIdentity.cpp#189
then, which puts PR_smprintf("mail.identity.%s.%s", identityKey, prefName); as
a prefix to the prefname.

        Attachment #160634 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch 2 (obsolete)
        — 
          — Splinter Review
      

    


  
this should do it...

    
    

    
  


  
Doing what Bug 178328 Comment 9 suggested, makes sense to me and causes less
confusion :).

        Attachment #160642 -
        Attachment is obsolete: true

    
  
Summary: Pref mail.identity.default.bcc_list is unused → Add a explaining comment to mail.identity.default.bcc_*

    
  

        Attachment #160643 -
        Flags: superreview?(bienvenu)

    
  

        Attachment #160643 -
        Flags: superreview?(bienvenu) → superreview+

    
  

        Attachment #160643 -
        Flags: review?(bienvenu)

    
  

        Attachment #160643 -
        Flags: review?(bienvenu) → review+

    
    

    
  
Checking in mailnews/mailnews.js;
/cvsroot/mozilla/mailnews/mailnews.js,v  <--  mailnews.js
new revision: 3.229; previous revision: 3.228
done

Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: Add a explaining comment to mail.identity.default.bcc_* → Add an explaining comment to mail.identity.default.bcc_*
Product: MailNews → Core
Product: Core → MailNews Core

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: