262249 - mozilla/tbird/firefox fails on build of nsCSSScanner.cpp using Sun Forte Developer 6.0 Update 2 compiler.

Status: RESOLVED FIXED

Description

[Mitch]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8a4) Gecko/20040928
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8a4) Gecko/20040928

Building any of the mozilla and related reptiles on Solaris with the Sun Forte
Compiler yeilds

"nsCSSScanner.cpp", line 906: Error: nsSubstring::nsSubstring(const
nsSubstring&) is not accessible from nsCSSScanner::SkipCComment(unsigned&).
1 Error(s) detected.
gmake[6]: *** [nsCSSScanner.o] Error 1
gmake[6]: *** Waiting for unfinished jobs....

This is most likely due to the CVS checking yesterday for bug 261283



Reproducible: Always
Steps to Reproduce:
1. Compilemozilla/thunderbird/firefox
2.
3.

Actual Results:  
Build fails

Comment 1

[Calum Mackay]

I think that by "forte" Mitch means the latest Sun compiler release: Sun Studio 9.

Mitch: am I right?

Comment 2

[Mitch]

It's actually the Workshop 6.0u2 compilers. Don't know what the packaging name
is though.

Comment 3

[Calum Mackay]

Sorry, my mistake. That is the (old) Forte compilers, then. Updating the
Summmary to clarify.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Also seeing this (trying to build current CVS Mozilla Suite).

Comment 5

[Mitch]

Created attachment 161876 [details] [diff] [review]
Patch

I'm fedup with no one fixing this even though this is a major blocker for
testing solaris builds. I've fixed it myself. I believe this is the correct fix
using C stringification and compiles fiferox/tbird/mozilla correctly.
Alterantively for Solaris builds one can hack out the CSS_REPORT_PARSE_ERRORS
nsCSSScanner.h which is clearly the wrong thing to do. Can someone confirm the
fix on other platforms and sr/sr+ please and check in ? Thanx

Comment 6

[Calum Mackay]

confirmed.

Comment 7

[Calum Mackay]

confirmed the bug, that is, and the fix on Solaris/SPARC.

Comment 8

[David Baron :dbaron: ⌚️UTC-7]

Comment on attachment 161876 [details] [diff] [review]
Patch

I don't get it.  The code you're patching doesn't exist anymore and was never
turned on.

Comment 9

[David Baron :dbaron: ⌚️UTC-7]

Er, oh, never mind.  I didn't know that code was there.  It shouldn't be.

Comment 10

[David Baron :dbaron: ⌚️UTC-7]

Created attachment 161882 [details] [diff] [review]
patch

Comment 11

[Boris Zbarsky [:bz] (no decent commit message means r-)]

Comment on attachment 161882 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 12

[David Baron :dbaron: ⌚️UTC-7]

Fix checked in to trunk, 2004-10-12 11:44 -0700.