Closed Bug 262254 Opened 20 years ago Closed 20 years ago

Help viewer has no title in trunk builds

Categories

(SeaMonkey :: Help Viewer, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 261267

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

Details

Attachments

(1 obsolete file)

In trunk builds like Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20040930 Firefox/0.9.1+ and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a4) Gecko/20040927, the Help Viewer has no title. It should be "Mozilla Firefox Help" in Firefox.
Attached patch use document.title (obsolete) — Splinter Review
DOMi says that the title attribute is set, but the title doesn't show up. I don't know why helpWindow.setAttribute("title", title); doesn't work, but document.title (title); works fine. The helpWindow var isn't used elsewhere in help.js.
Attachment #160622 - Flags: review?(neil.parkwaycc.co.uk)
Yeah, I changed it without checking for side-effects, see attachment 160176 [details] [diff] [review]
Target Milestone: --- → After Firefox 1.0
Other dialogs are broken as well. Bug 261267 has a patch for all of them. *** This bug has been marked as a duplicate of 261267 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Target Milestone: After Firefox 1.0 → ---
Attachment #160622 - Attachment is obsolete: true
Attachment #160622 - Flags: review?(neil.parkwaycc.co.uk)
Product: Firefox → Toolkit
Version: Trunk → unspecified
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: