262274 - visibility of PK11_GetCertFromPrivateKey and CERT_DecodeDERCertificate

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Caolan McNamara]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040929
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040929

OpenOffice.org 1.9.54 attempt to make use of PK11_GetCertFromPrivateKey and 
CERT_DecodeDERCertificate from libnss3.so. OOo has patched their own build to
provide visible PK11_GetCertFromPrivateKey and CERT_DecodeDERCertificate symbols
from libnss3.so
(http://external.openoffice.org/source/browse/external/moz/Attic/mozillasource-1.7b.patch)
by adding them to nss.def (e.g.
http://people.redhat.com/caolanm/systemmozilla/mozilla.nss.OpenOffice.org.patch)

They are listed in the nss/pk11func.h and nss/cert.h headers. Should they be
visible from libnss3.so ? Or should use not be made of them from external
applications ? (mozilla 1.7.3)

Reproducible: Always
Steps to Reproduce:
1. compile something using PK11_GetCertFromPrivateKey &
CERT_DecodeDERCertificate from nss/pk11func.h and nss/cert.h
2. link against libnss3.so for PK11_GetCertFromPrivateKey &
CERT_DecodeDERCertificate
Actual Results:  
fails to link

Expected Results:  
link happily

Comment 1

[Wan-Teh Chang]

Bob, Nelson, could you look at this?  Is it okay
to export PK11_GetCertFromPrivateKey and
CERT_DecodeDERCertificate?

I remember we debated CERT_DecodeDERCertificate
when Nelson tried to make crmftest work again
(bug 244329. see also bug 243245).

Comment 2

[Robert Relyea]

OpenOffice.org should not be using CERT_DecodeDERCertificate. The cert returned
from that function is not a 'complete' cert. Instead, import the cert as a temp
cert.

(if we separated the 'cert decoding' from the cert representation, then we could
crack a cert without importing it. Stan API's are designed to do that).

There is no reason not to export PK11_GetCertFromPrivateKey, however.

bob

Comment 3

[Caolan McNamara]

So if there's no reason not to export PK11_GetCertFromPrivateKey will it be
exported in a future release ?

Comment 4

[Robert Relyea]

Attachment: Export PK11_GetCertFromPrivatekey

Good point.

This patch puts the export in NSS 3.10. If we need it sooner I can supply a
separate patch that puts it in NSS 3.9.x, though I think we're trying to close
3.9.3 shortly?

Comment 5

[Wan-Teh Chang]

Comment on attachment 162083 [details] [diff] [review]
Export PK11_GetCertFromPrivatekey

This is a simple change.  I can export the
function in NSS 3.9.3.	Any objections?

I plan to close NSS 3.9.3 today.

Comment 6

[Robert Relyea]

Attachment: 3.9.3 version of patch (add PK11_GetCertFromPrivateKey

The 3.9 version of the patch.

Comment 7

[Robert Relyea]

Attachment: new 3.10 patch.

This patch also updates the 3.10 branch to be consistant with the 3.9.3 export
list. (there were two missing functions).

Since we plan to export this in 3.9.3, we need to move the export the 3.9.3
export block in our 3.10 patch

Comment 8

[Robert Relyea]

Comment on attachment 162102 [details] [diff] [review]
3.9.3 version of patch (add PK11_GetCertFromPrivateKey

wtc: please review

Comment 9

[Robert Relyea]

Comment on attachment 162103 [details] [diff] [review]
new 3.10 patch.

wtc please review

Comment 10

[Robert Relyea]

Attachment: Move PK11_GetCertFromPrivateKey from the private headers to the public headers.

This change doesn't have a compile issue since on NSS 3.10 pk11priv.h and
pk11pub.h are new and both are included in pk11func.h, but the current rules
are anything publically exported should be in a public header, so this change
is needed for cleanliness.

No equivalent change is needed in NSS 3.9.3 since all the functions are listed
in pk11func.h flat without any indication of which are public and which are
private.

bob

Comment 11

[Robert Relyea]

All the patches are checked into the appropriate branches. (including the header
change for NSS 3.10).

bob

Comment 12

[Wan-Teh Chang]

Marked the bug fixed.