262779 - [l10n] ExportedBookmarkFile text not localizable

Status: RESOLVED FIXED

(Camino Graveyard :: Translations, defect)

Description

[Petteri Kamppuri]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.2) Gecko/20040825 Camino/0.8.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.2) Gecko/20040825 Camino/0.8.1

Default file name, "ExportedBookmarkFile", for exporting bookmarks is not
localizable.

Reproducible: Always
Steps to Reproduce:
1. Select Export Bookmarks from the File menu
2. See what the dialog box says.



Expected Results:  
It should've given me a default localized version of the file name.

Comment 1

[Ludovic Hirlimann [:Usul]]

Confirming. In MainController.mm
we have 
"int saveResult = [savePanel runModalForDirectory:nil
file:NSLocalizedString(@"ExportedBookmarkFile", @"Exported Bookmarks")];"

there is no such entry in localized.string

Mike do you need a patch for this bug ?

Comment 2

[Ludovic Hirlimann [:Usul]]

Also since we do bookmark stuff in 0.8.2 it would be nice if that one got included.

Comment 3

[Ludovic Hirlimann [:Usul]]

Attachment: Corrected Localized strings

Comment 4

[Geoff "temporarily off bugmail" Beier]

(In reply to comment #3)
> Created an attachment (id=161057)
> Corrected Localized strings
> 

In your Localizable.strings you have:
"Exported Bookmarks" = "ExportedBookmarkFile";
Shouldn't it be:
"ExportedBookmarkFile" = "Exported Bookmarks";

Comment 5

[Ludovic Hirlimann [:Usul]]

Attachment: Localized.strings containg the right string

NeXT time I'll take my time before submiting.

Comment 6

[Josh Aas]

Comment on attachment 161175 [details]
Localized.strings containg the right string

looks good to me

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 161175 [details]
Localized.strings containg the right string

sr=pink.

go for it.

Comment 8

[Josh Aas]

landed on trunk and MOZILLA_1_7_BRANCH