262800 - Credits start to scroll before activated

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Ross Shannon]

When viewing Help | About Mozilla Firefox, if you wait for about 5 seconds
before clicking the Credits button, the credits crawl will have started
scrolling already in the background. It then restarts, but the jump is noticable
and irksome. Can't we just start it when that pane is switched to?

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041003
Firefox/0.10

WFM

Comment 2

[Peter van der Woude [:Peter6]]

oops, had clicked too fast
Confirming

Comment 3

[Daryle Walker]

It happens on the Mac OS X edition of Firefox too, even up to
version 1.5b2.  (So if others can check other environments,
maybe we should change effected hardware/OS to "All".)

Comment 4

[Declan Naughton]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060311 Firefox/1.6a1

Confirmed. I don't think it's an OS dependent thing...

Comment 5

[Declan Naughton]

Attachment: fix - remove the src attribute from the creditsIframe so it doesn't run immediatly when the about dialog is opened

Comment 6

[Declan Naughton]

Whenever I confirmed above I was getting a slightly different behaviour to that reported originally (only noticed now).

On "Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060311 Firefox/1.6a1", going to Help | About, waiting for 10 seconds and then clicking the credits button would result in the credits crawling from a good bit into them - the credits.xhtml page was already running and not refreshed (in the original report, it was refreshed, after a short but noticeable while. The page isn't refreshed on the Windows nightlies either, so it must be a HEAD thing.).

The patch I attached above results in the credits.xhtml file not being rendereed/started when the about window is open - it is loaded/refreshed when the credits button is clicked from the about page.

Comment 7

[Reed Loden [:reed]]

Heh, you're absolutely right.

Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060802 BonEcho/2.0b1 ID:2006080203.

Comment 8

[Reed Loden [:reed]]

Comment on attachment 214871 [details] [diff] [review]
fix - remove the src attribute from the creditsIframe so it doesn't run immediatly when the about dialog is opened

Actually, if I'm allowed, I'll just review this myself. Just fwap me if this is not permitted. :)

My reasons behind why this is correct:
* aboutDialog.js just sets |src| to "" when it switches the page again.
* The |src| parameter is optional.
* Without a |src| parameter, the credits page will not load until the button is pressed and the JavaScript in aboutDialog.js swaps the page and sets the |src|.

I hope this suffices for review.

r=reed

Comment 9

[Reed Loden [:reed]]

Comment on attachment 214871 [details] [diff] [review]
fix - remove the src attribute from the creditsIframe so it doesn't run immediatly when the about dialog is opened

Requesting a1.8.1 for this small fix to stop the credits from being scrolled while the actual credits page is not loaded.

Comment 10

[Mike Schroepfer]

Comment on attachment 214871 [details] [diff] [review]
fix - remove the src attribute from the creditsIframe so it doesn't run immediatly when the about dialog is opened

Mike C. should really do a review on any browser-stuff.

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 214871 [details] [diff] [review]
fix - remove the src attribute from the creditsIframe so it doesn't run immediatly when the about dialog is opened

r+a=me on behalf of drivers for 1.8 branch checkin

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/aboutDialog.xul 	1.23.4.7
mozilla/browser/base/content/aboutDialog.xul 	1.26