262807 - Updates button doesn't appear if using an old profile and having customized toolbars

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Steffen Wilberg]

When using an old profile, which was created with a build not newer than August,
and having customized the toolbars, the Updates button doesn't appear when
updates are available.

The button was introduced on 2004-08-31 22:01. It is on the menubar on Windows
and Linux, and on the navigation toolbar on Mac.

1. Create a new profile with an old build. I used 0.9.2.
2. Exit Firefox.
3. Start a recent build.
4. Go to Tools-Options-Advanced-Software Update, click Check Now (so that
Firefox learns that updates are available).
Result: The Update button appears.

5. Create another new profile with an old build.
6. Customize the Toolbar (add a button).
7. Exit Firefox.
8. Start a recent build.
9. Go to Tools-Options-Advanced-Software Update, click Check Now.
Result: No Update button appears!

10. Go to Customize Toolbars, click on Restore Default Set.
Result: The Update button is added to the menubar.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Can we put the update icon back in the status bar?  I can't find the original
bug for moving it out of there; doesn't make sense for it to take up toolbar
space when 90% of the time it'll just be green.  Also doesn't make sense to let
users take it off the toolbar, for that 10% time when it won't be green.

Comment 2

[Daniel Veditz [:dveditz]]

Most of the time isn't the icon simply not there? Green indicates updates
available; after I updated all my extensions the icon went away completely.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #2)
> Most of the time isn't the icon simply not there? Green indicates updates
> available; after I updated all my extensions the icon went away completely.

Ah.  I guess I should have clicked on it, it was green -- green indicates
"Everything's OK to me".

Comment 4

[Daniel Veditz [:dveditz]]

Wait, users have to click a button to get the icon to update? What's the point
then? You could just put up the dialog listing the avaiable updates straight
away, the user has asked for it explicitly after all. I thought the idea was to
magically show up and give a warning about critical updates to users who won't
know to click on a check-updates button.

In my case I don't recall ever customizing a toolbar (I did open the dialog, but
didn't see anything I wanted to add). I never got an update icon until after I
clicked "Check Now".

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

No, I meant that I added the button to my toolbar and saw that it was green, and
assumed that meant "everything's ok, no updates available".

Comment 6

[Steffen Wilberg]

The "update.severity" pref controls the color.
0: "Green" means there are Extension/Theme updates available, but not more than
a threshold specified in the pref "extensions.update.severity.threshold", which
defaults to 5.

1: "Blue" means there are Extension/Theme updates available, and their number is
larger than the threshold.

2: "Red" means an app update is available.

You can set that pref in about:config and open a new window if you want to see
how the colors look like. Green is probably a bit misleading. At least there's a
tooltip saying "Update(s) available".


I can only reproduce this if I customize my toolbar in an old build. The setting
is saved in localstore.rdf,
RDF:about="chrome://browser/content/browser.xul#nav-bar".

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

There's something else going on then; upon clicking the green button, I had an
app update, an extension update, theme updates, and optional components (both of
which I already had installed).  I installed the app update, and ffox is still
offering it to me (and the icon is still green).

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

programmatically add the updates item in the right place on mac and other
platforms - to ensure it can't be customized away.

Comment 9

[Steffen Wilberg]

This broke the update notification. See bug 263606, which has a patch ready for
review.