Closed
Bug 262833
Opened 20 years ago
Closed 20 years ago
[FIXr]nsRangeUtils could be a service
Categories
(Core :: DOM: Editor, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
25.03 KB,
patch
|
glazou
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
There is really no reason for nsRangeUtils to be a multiple-instance thing (right now editor creates it via CreateInstance()). It's just a shim to call into static nsRange methods, so it could easily be a service. If there are no objections from jst, peterv, sicking, I'll go ahead and make that change.
|
||
Comment 1•20 years ago
|
||
Sounds like a good thing to change to me...
|
Assignee | |
Comment 2•20 years ago
|
||
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 161224 [details] [diff] [review] Ptch This ended up including the fix for bug 262832, in the end...
Attachment #161224 -
Flags: superreview?(jst)
Attachment #161224 -
Flags: review?(daniel)
|
|
||
Comment 4•20 years ago
|
||
Comment on attachment 161224 [details] [diff] [review] Ptch sr=jst
Attachment #161224 -
Flags: superreview?(jst) → superreview+
Comment on attachment 161224 [details] [diff] [review] Ptch r=daniel@glazman.org
Attachment #161224 -
Flags: review?(daniel) → review+
|
|
Assignee | |
Updated•20 years ago
|
Summary: nsRangeUtils could be a service → [FIXr]nsRangeUtils could be a service
|
|
Assignee | |
Updated•20 years ago
|
Assignee: mozeditor → bzbarsky
Priority: -- → P1
Target Milestone: --- → mozilla1.8alpha5
|
|
Assignee | |
Comment 6•20 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•